Ticket #3651 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

[with patch, positive review] elliptic curves -- bug in L_ratio()

Reported by: cremona Assigned to: was
Priority: major Milestone: sage-3.0.6
Component: number theory Keywords:
Cc: nbruin@cecm.sfu.ca

Description

Nils Bruin reports:

"I ran into the following problem in sage, and I suspect it might be your code: 

sage: EllipticCurve([0,0,0,-193^2,0]).sha().an()
[...]
NameError: global name 'misc' is not defined

Was this tested at all?"

It's a problem in L_ratio().

Attachments

sage-trac3651.patch (1.1 kB) - added by cremona on 07/13/2008 12:44:30 PM.

Change History

07/13/2008 12:44:30 PM changed by cremona

  • attachment sage-trac3651.patch added.

07/13/2008 12:45:47 PM changed by cremona

  • summary changed from elliptic curves -- bug in L_ratio() to [with patch, needs review] elliptic curves -- bug in L_ratio().

After the attached patch (based on 3.0.4) it works fine: 

sage: EllipticCurve([0,0,0,-193^2,0]).sha().an()
4

07/13/2008 12:49:01 PM changed by mabshoff

  • milestone set to sage-3.0.6.

See http://groups.google.com/group/sage-devel/t/60a62f8337e4de3a for details.

Cheers,

Michael

07/14/2008 03:14:09 AM changed by wuthrich

Does not work with me, did you mean import sage.misc.misc as misc ?

07/14/2008 05:14:58 AM changed by wuthrich

Sorry, my mistake; it works of course.

07/15/2008 09:09:51 PM changed by mabshoff

  • summary changed from [with patch, needs review] elliptic curves -- bug in L_ratio() to [with patch, positive review] elliptic curves -- bug in L_ratio().

Taking Chris' remark into account I am giving this a positive review.

Cheers,

Michael

07/15/2008 09:24:26 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Merged in Sage 3.0.6.alpha0