Ticket #3649 (closed defect: fixed)

Opened 2 months ago

Last modified 3 weeks ago

[with patch, positive review] Add option to disable the Notebook registration email

Reported by: mabshoff Assigned to: TimothyClemans
Priority: major Milestone: sage-3.1
Component: notebook Keywords:
Cc:

Description

From https://groups.google.com/group/sage-support/browse_thread/thread/1fc876f97a69eb5e

When you sign up for a Sage Notebook account, Sage sends an e-mail to
the address you provide giving you a link to complete the
registration.

First of all, the "Sign up for a Sage Notebook account" says that the
e-mail is needed if you forget your password, but makes no mention of
the fact that the e-mail will be needed immediately to complete the
registration process. If Sage asks for a user's e-mail address, it
should correctly indicate what that e-mail address is for. Otherwise,
e-mail from the Sage notebook is technically spam.

Secondly, I am running the Sage notebook on a machine which my
college's support staff will not allow to run a mail server (all of
the mail on campus needs to be handled by their own antiquated
servers, which has less storage space than my iPod to store e-mail for
2000 users). Is there any way to turn off the sending of e-mail from
the Sage Notebook?

-- Greg

-- 
Gregory D. Landweber
Assistant Professor of Mathematics
Bard College 

Robert Bradshaw replied:

Thanks for the clarification. This can easily be resolved by  
commenting out line ~1716 of sage/server/notebook/twist.py. This  
should probably be made optional and configurable somewhere.

- Robert 

Cheers,

Michael

Attachments

extcode-3649_1.patch (0.9 kB) - added by TimothyClemans on 08/03/2008 03:10:21 PM.
extcode-3649_2.patch (1.5 kB) - added by TimothyClemans on 08/04/2008 01:15:48 PM.
sage-3649.patch (13.2 kB) - added by TimothyClemans on 08/04/2008 01:16:02 PM.

Change History

07/13/2008 05:34:51 PM changed by TimothyClemans

  • owner changed from boothby to TimothyClemans.
  • status changed from new to assigned.

Lines to copy out are

1984            # Send a confirmation message to the user.
1985            try:
1986                send_mail(self, fromaddr, destaddr, "Sage Notebook Registration",body)
1987                waiting[key] = filled_in['username']
1988            except ValueError:
1989                pass

If 3.0.6 comes out few days after August 1st then instead of copying this out I'll make the email inputbox optional by the admin with the default set to False.

'email_system' = False

08/03/2008 03:10:21 PM changed by TimothyClemans

  • attachment extcode-3649_1.patch added.

08/03/2008 03:13:15 PM changed by TimothyClemans

  • summary changed from Add option to disable the Notebook registration email to [with patch, do not review] Add option to disable the Notebook registration email.

Point #1 addressed by extcode-3649_1.patch. I'm starting to address #2. I will make email optional. If email services are off then automated account recovery will be disabled.

08/04/2008 01:15:48 PM changed by TimothyClemans

  • attachment extcode-3649_2.patch added.

08/04/2008 01:16:02 PM changed by TimothyClemans

  • attachment sage-3649.patch added.

08/04/2008 01:17:01 PM changed by TimothyClemans

  • summary changed from [with patch, do not review] Add option to disable the Notebook registration email to [with patch, needs review] Add option to disable the Notebook registration email.

08/04/2008 01:21:18 PM changed by TimothyClemans

Note: there is a script for applying the various Notebook patches. The base is sage-3.0.6.

http://sage.math.washington.edu/home/tclemans/uw_contract_work/apply_patches.sage

08/04/2008 10:01:19 PM changed by was

  • summary changed from [with patch, needs review] Add option to disable the Notebook registration email to [with patch, positive review] Add option to disable the Notebook registration email.
  • milestone changed from sage-3.1.1 to sage-3.1.

WOW, this is very very nice; works perfectly.

Enthusiastic positive review.

08/09/2008 05:29:18 PM changed by mabshoff

  • status changed from assigned to closed.
  • resolution set to fixed.

Merged in Sage 3.1.alpha1