Ticket #3648 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

[with patch, positive review] complex(pari(...)) fails

Reported by: cwitty Assigned to: somebody
Priority: major Milestone: sage-3.0.6
Component: basic arithmetic Keywords:
Cc:

Description

Pari gen objects should have a __complex__ method, so that complex(...) works on them.

Attachments

trac3648-gen-complex.patch (1.1 kB) - added by cwitty on 07/12/2008 09:24:31 AM.
trac3648-gen-complex-2.patch (0.8 kB) - added by dmharvey on 07/13/2008 09:54:28 PM.

Change History

07/12/2008 09:24:31 AM changed by cwitty

  • attachment trac3648-gen-complex.patch added.

07/13/2008 09:44:34 PM changed by dmharvey

  • summary changed from [with patch, needs review] complex(pari(...)) fails to [with patch, under review by dmharvey] complex(pari(...)) fails.

07/13/2008 09:54:28 PM changed by dmharvey

  • attachment trac3648-gen-complex-2.patch added.

07/13/2008 09:55:05 PM changed by dmharvey

  • summary changed from [with patch, under review by dmharvey] complex(pari(...)) fails to [with patch, needs more review] complex(pari(...)) fails.

I've added a further doctest to cover the case when "complex" doesn't make sense.

cwitty: if you're happy with that, this has a positive review from me.

07/15/2008 09:04:42 PM changed by cwitty

  • summary changed from [with patch, needs more review] complex(pari(...)) fails to [with patch, positive review] complex(pari(...)) fails.

dmharvey's patch looks good to me, and doctests pass in sage/libs/pari.

07/15/2008 09:45:27 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Merged in Sage 3.0.6.alpha0