Ticket #3619 (assigned enhancement)

Opened 12 months ago

Last modified 11 months ago

[with patch, needs work] notebook -- record date & time each user logs in

Reported by: TimothyClemans Owned by: TimothyClemans
Priority: major Milestone: sage-4.1
Component: notebook Keywords:
Cc: Reviewer(s):
Author(s): Merged in:

Description


Attachments

sage-3619.patch (4.5 KB) - added by TimothyClemans 11 months ago.
Depends on #3776

Change History

  Changed 12 months ago by TimothyClemans

  • owner changed from boothby to TimothyClemans
  • status changed from new to assigned

  Changed 12 months ago by TimothyClemans

  • summary changed from notebook -- record date & time each user logs in to [with patch, needs review] notebook -- record date & time each user logs in

I couldn't seem to figure out how to get AdminToplevel? to be the toplevel for admins.

follow-up: ↓ 4   Changed 11 months ago by ncalexan

I don't understand what the final comment, about AdminToplevel?, is about.

I worry that we will hang on to thousands of login times with this, which could be memory/disk intensive. Could we agree on the last fifty login times, or the first time ever and then the next 100 or something similar?

Also, there is no way to view this information. Why are we keeping it?

in reply to: ↑ 3   Changed 11 months ago by TimothyClemans

Replying to ncalexan:

I don't understand what the final comment, about AdminToplevel?, is about.

Somehow the user account type for the user admin was getting changed to 'user'. This is no longer a problem because a patch was merged which has account_type returning 'admin' for user admin no matter what.

I worry that we will hang on to thousands of login times with this, which could be memory/disk intensive. Could we agree on the last fifty login times, or the first time ever and then the next 100 or something similar?

We could, but I am very interested in being able to look up all login times for a given user.

Also, there is no way to view this information. Why are we keeping it?

There will be. I just didn't do it because at the time I couldn't figure out the AdminToplevel? problem.

I'll get back to this ticket after thinking more about it. Thanks for reviewing.

  Changed 11 months ago by TimothyClemans

  • summary changed from [with patch, needs review] notebook -- record date & time each user logs in to [with patch, needs work] notebook -- record date & time each user logs in

  Changed 11 months ago by TimothyClemans

  • summary changed from [with patch, needs work] notebook -- record date & time each user logs in to [with patch, needs review] notebook -- record date & time each user logs in

How I test this:

(1) I login and then go to sage.math.washington.edu:8999/users # Table of users with two links next to each of them if login recording is on.

(2) I click on "Access" in third column to see login times. The page should be blank if no login times have been recorded.

Login recording is turned off by default. In order to turn it on I do:

*** WARNING: Notebook must not be running! ***

sage: nb = load('.sage/sage_notebook/nb.sobj', compress=False)
sage: nb.conf()['record_logins'] = True
sage: nb.save(filename='/home/tclemans/.sage/sage_notebook/nb.sobj')

Changed 11 months ago by TimothyClemans

Depends on #3776

  Changed 11 months ago by TimothyClemans

  • summary changed from [with patch, needs review] notebook -- record date & time each user logs in to [with patch, needs work] notebook -- record date & time each user logs in
Note: See TracTickets for help on using tickets.