Ticket #3601 (closed enhancement: fixed)

Opened 5 months ago

Last modified 5 months ago

[with patch, positive review] Reimplementation of tensor products

Reported by: aschilling Assigned to: Mike Hansen
Priority: minor Milestone: sage-3.0.6
Component: combinatorics Keywords: tensor products of crystals
Cc: sage-combinat-commits@googlegroups.com

Description

I split TensorProductOfCrystals? into TensorProductOfCrystalsWithGenerators? and FullTensorProductOfCrystals? (with or without the option of being a classical crystal). This makes it possible to have a more efficient way to access list, count, etc for tensor products that do not have module generators.

Also, the distinction between the specifications of module_generators and highest_weight_vectors is made more precise (which made it necessary to slightly change the implementation of Daniel Bump on characters).

This change is necessary for the upcoming implementation of affine crystals.

Attachments

tensor_product-for_trac.patch (9.4 kB) - added by aschilling on 07/07/2008 08:39:19 PM.
tensor_product-3601-review.patch (5.5 kB) - added by mhansen on 07/09/2008 01:45:14 PM.

Change History

07/07/2008 08:39:19 PM changed by aschilling

  • attachment tensor_product-for_trac.patch added.

07/09/2008 01:45:14 PM changed by mhansen

  • attachment tensor_product-3601-review.patch added.

07/09/2008 01:46:43 PM changed by mhansen

  • summary changed from Reimplementation of tensor products to [with patch, under review by mhansen] Reimplementation of tensor products.

Hi Anne,

I added a few doctests and fixed some whitespace issues (there were tabs instead of spaces). If you're fine with these changes, I'll go ahead and give it a positive review so it can get merged.

--Mike

07/09/2008 02:18:17 PM changed by aschilling

Hi Mike,

Yes, your changes look fine to me (I wonder how the tabs instead of spaces happened to be wrong?).

Anne

07/09/2008 02:20:18 PM changed by mhansen

  • summary changed from [with patch, under review by mhansen] Reimplementation of tensor products to [with patch, positive by mhansen] Reimplementation of tensor products.

I'm not sure. Usually the editor picks that up just fine.

07/09/2008 06:41:01 PM changed by mabshoff

Anne, Mike,

to be 100% clear: both patches should be applied in this case?

Cheers,

Michael

07/09/2008 06:54:10 PM changed by mhansen

Yes, both patches.

07/15/2008 08:51:27 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.
  • summary changed from [with patch, positive by mhansen] Reimplementation of tensor products to [with patch, positive review] Reimplementation of tensor products.

Merged in Sage 3.0.6.alpha0