Ticket #3599 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

[with patch, positive review] Longer slider and labels on sliders

Reported by: itolkov Owned by: itolkov
Priority: major Milestone: sage-3.1
Component: notebook Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

Slider update:

  • Sliders are now version 3, which is similar to current version 1, but longer
  • Label to the right of slider containing the current slider value (string representation), which is updated dynamically
  • User can hide label with "display_value=False".

Attachments

trac3599_sage_1.patch Download (9.5 KB) - added by itolkov 2 years ago.
trac3599_extcode_1.patch Download (2.4 KB) - added by itolkov 2 years ago.
trac3599_extcode_2.patch Download (382 bytes) - added by was 2 years ago.
the image of the slider
slider-bg-3.png Download (239 bytes) - added by itolkov 2 years ago.
Here's the png again.

Change History

Changed 2 years ago by itolkov

Changed 2 years ago by itolkov

Changed 2 years ago by itolkov

  • summary changed from Longer slider and labels on sliders to [with patch, needs review] Longer slider and labels on sliders

Changed 2 years ago by itolkov

  • priority changed from minor to major

Changed 2 years ago by itolkov

  • milestone set to sage-3.0.6

Changed 2 years ago by jason

Where does the png file go?

Changed 2 years ago by jason

  • summary changed from [with patch, needs review] Longer slider and labels on sliders to [with patch, positive review] Longer slider and labels on sliders

Answering my question, it goes in:

$SAGE_ROOT/data/extcode/notebook/javascript/jqueryui/themes/flora/i/slider-bg-3.png

This patch seems to do what it claims and looks like reasonable code, looks nice, and doctests pass in sage/server/notebook/*.py

+1

Changed 2 years ago by was

the image of the slider

Changed 2 years ago by was

I replaced the png by a proper patch.

Changed 2 years ago by was

I give this another positive review, by the way. Very good.

Changed 2 years ago by mabshoff

  • summary changed from [with patch, positive review] Longer slider and labels on sliders to [with patch, positive review, partially merged] Longer slider and labels on sliders

Merged trac3599_sage_1.patch and trac3599_extcode_1.patch in Sage 3.1.alpha0. trac3599_extcode_2.patch is empty. You need to add a git style patch or reattach the png.

Cheers,

Michael

Changed 2 years ago by itolkov

Here's the png again.

Changed 2 years ago by mabshoff

  • status changed from new to closed
  • summary changed from [with patch, positive review, partially merged] Longer slider and labels on sliders to [with patch, positive review] Longer slider and labels on sliders
  • resolution set to fixed
  • milestone changed from sage-3.1.1 to sage-3.1

Merged slider-bg-3.png in Sage 3.1.alpha0. Thanks Igor for the png. In the future please export a git style patch in case binaries are involved.

Cheers,

Michael

Note: See TracTickets for help on using tickets.