Ticket #3543 (new enhancement)

Opened 2 years ago

Last modified 4 months ago

Unify jquery libraries in devel/sage and data/extcode

Reported by: mabshoff Owned by:
Priority: minor Milestone: sage-4.5.3
Component: build Keywords:
Cc: jason, timdumol Author(s):
Report Upstream: N/A Reviewer(s):
Merged in: Work issues:

Description

We currently ship two copies of the jquery javascript library:

  • jQuery 1.2.6 - New Wave Javascript - $Rev: 5685 $ in devel/sage-main/sage/dsage/web/static/jquery.js
  • jQuery 1.2.3 - New Wave Javascript - $Rev: 4663 $ in data/extcode/notebook/javascript/jquery/jquery.js

But we should on ship one copy.

Cheers,

Michael

Change History

Changed 23 months ago by jason

  • cc jason added
  • owner changed from was to jason
  • status changed from new to assigned

Changed 21 months ago by jason

  • owner jason deleted
  • status changed from assigned to new

Changed 21 months ago by jason

I'm not sure what is going on with dsage; someone familiar with dsage will have to look at that.

Changed 20 months ago by jason

  • priority changed from major to minor
  • type changed from defect to enhancement

All that is needed is that dsage needs to change its /static directory to point to local/notebook/javascript/<appropriate directory>. I'm making this minor since:

  1. the small space wasted with duplicated code is not worth the risk of breaking dsage, especially since
  2. it seems that the future of dsage is uncertain.

Things work now.

Changed 4 months ago by jason

  • cc timdumol added
  • upstream set to N/A

Tim,

Can you comment on this ticket? You probably know more about this than anyone at this point.

Changed 4 months ago by timdumol

dsage is gone, so that doesn't matter. The files in data/extcode/... are used by the old notebook (in sage.server.notebook). Since the old notebook isn't used anymore except in migration to the new one, the files should be safe to delete.

Note: See TracTickets for help on using tickets.