Ticket #3500 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, with positive review] bug in cyclotomic linear algebra code

Reported by: craigcitro Owned by: craigcitro
Priority: major Milestone: sage-3.0.4
Component: linear algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Wow, here's an embarrassing bug in the cyclotomic linear algebra code: 

sage: cf4 = CyclotomicField(4) ; z4 = cf4.0
sage: A = Matrix(cf4, 1, 2, [-z4, 1])
sage: A.echelon_form()

[1 0]
[0 1]

The attached patch fixes it.

Attachments

trac-3500.patch Download (2.6 KB) - added by craigcitro 5 years ago.

Change History

Changed 5 years ago by craigcitro

comment:1 Changed 5 years ago by cpernet

  • Summary changed from [with patch, needs review] bug in cyclotomic linear algebra code to [with patch, with review] bug in cyclotomic linear algebra code

This patch looks correct and fixes the bug. The docstrings pass on 3.0.4alpha1.

comment:2 Changed 5 years ago by cpernet

  • Summary changed from [with patch, with review] bug in cyclotomic linear algebra code to [with patch, with positive review] bug in cyclotomic linear algebra code

comment:3 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.0.4.alpha1

Note: See TracTickets for help on using tickets.