Ticket #3479 (closed enhancement: fixed)
[with patch, positive review] update dsage portion of tut.tex
| Reported by: | yi | Owned by: | mhansen |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.4 |
| Component: | documentation | Keywords: | editor_mhansen |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
This patch provides 2 more examples on how to use the distributed map() function in dsage as well as the @parallel decorator.
To get the tutorial to build correctly I needed to remove all the temporary files and run the 'build_pdf' script twice to generate the index.
This patch depends on #3467 and the @parallel decorator patches going in.
Attachments
-
3479_dsage_tut.patch
(1.8 KB) -
added by yi 5 years ago.
- Patch for doc/tut/tut.tex
Change History
Changed 5 years ago by yi
-
attachment
3479_dsage_tut.patch
added
comment:4 Changed 5 years ago by jhpalmieri
- Summary changed from [with patch, needs review] update dsage portion of tut.tex to [with patch, needs work] update dsage portion of tut.tex
The patch fails against the current version of the tutorial.
When applied manually, the patch seems okay, and passes all doctests. A few comments:
In example 3, item 5, I would suggest changing $f$ to \code{f}, for the sake of better latex to html conversion.
In example 4, the verbatim block looks odd, especially in the live version of the tutorial.
If you fix at least example 3, and produce a patch against the current tutorial, I'll give it a positive review.
(In general, I find the style of using numbered instructions, as in all of the dsage examples, at odds with the style of the rest of the tutorial. It would be nice if this were rewritten, but that can wait for a separate trac item and patch.)
comment:5 Changed 5 years ago by jhpalmieri
By the way, what does "% (fold)" mean? This only appears in the dsage part of the tutorial, and I don't know what role it plays.
comment:6 Changed 4 years ago by mhansen
- Owner changed from tba to mhansen
- Status changed from new to assigned
- Summary changed from [with patch, needs work] update dsage portion of tut.tex to [with patch, positive review] update dsage portion of tut.tex
- Milestone changed from sage-3.4.1 to sage-3.4
I addressed the referee's comment and added this to the Sphinx version of the tutorial.
Patch for doc/tut/tut.tex