Ticket #3475 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] setup.py was missing jquery.form.js, upgrade to latest version of jquery (1.2.6) and jquery.form

Reported by: yi Owned by: was
Priority: critical Milestone: sage-3.0.4
Component: dsage Keywords: editor_mabshoff
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

jquery.form.js somehow got dropped from setup.py, which is needed for the web interface, it does *NOT* function correctly without the proper jquery plugin.

This patch also upgrades jquery, jquery.form to the latest version.

Attachments

3475_dsage_js.patch Download (136.4 KB) - added by yi 5 years ago.
renamed patch file to include bug #

Change History

Changed 5 years ago by yi

renamed patch file to include bug #

comment:1 Changed 5 years ago by craigcitro

  • Keywords editor_mabshoff added
  • Milestone changed from sage-3.1 to sage-3.1.1

comment:2 Changed 5 years ago by mabshoff

Yi,

can you split off the "missing jquery.form.js from setup.py" part from the jquery update? The copy part of the patch is trivial to review and will get into 3.0.4, I am not so sure about the jquery update since that should be done by somebody who works on the notebook and withb @interact for example.

Cheers,

Michael

comment:3 Changed 5 years ago by yi

Michael,

The jquery update is a non issue since AFAIK the notebook does not use the jquery version dsage uses.

It uses the one found here:

iapetus:~/Software/sage-3.0.3.rc0/data/extcode/notebook/javascript/jquery >

Maybe in the future we can simply provide one version, but that is another issue. Let me know if this resolves your complaint.

comment:4 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, needs review] setup.py was missing jquery.form.js, upgrade to latest version of jquery (1.2.6) and jquery.form to [with patch, positive review] setup.py was missing jquery.form.js, upgrade to latest version of jquery (1.2.6) and jquery.form

I agree that there are two copies of jquery and we can upgrade DSage's copy without having any repercussions on the notebook one. Positive review.

Cheers,

Michael

comment:5 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from sage-3.1.1 to sage-3.0.4

Merged in Sage 3.0.4.alpha2

Note: See TracTickets for help on using tickets.