Ticket #3467 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] implements @parallel decorator using dsage

Reported by: yi Owned by: yi
Priority: major Milestone: sage-3.0.4
Component: dsage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by was) (diff)

Here's how to use it:

sage: d = dsage.start_all()
Spawned twistd -d /Users/yqiang/.sage/dsage --pidfile=server.pid --logfile=/Users/yqiang/.sage/dsage/server.log -y dsage_server.tac (pid = 73563)

Spawned python /Users/yqiang/Software/sage-3.0.3.rc0/local/bin/dsage_worker.py -s localhost -p 8083 -u yqiang -w 2 --poll 1.0 -l 0 -f /Users/yqiang/.sage/dsage/worker.log --privkey=/Users/yqiang/.sage/dsage/dsage_key --pubkey=/Users/yqiang/.sage/dsage/dsage_key.pub --priority=20 --ssl --noblock (pid = 73571)

sage: P = parallel(p_iter = d.parallel_iter)
sage: @P
....: def MS1(N,k):
....:     return ModularSymbols(N,k,sign=1).decomposition(10)[0]
....: 
sage: time v = MS1([(250,2), (11,2), (37,2)])

Attachments

dsage_interface.2.patch Download (6.2 KB) - added by yi 5 years ago.
dsage_interface.patch Download (6.3 KB) - added by yi 5 years ago.
dsage_interface.3.patch Download (8.9 KB) - added by yi 5 years ago.
new patch with doctests.
dsage_interface.4.patch Download (9.0 KB) - added by yi 5 years ago.

Change History

comment:1 Changed 5 years ago by yi

  • Owner changed from tbd to yi
  • Component changed from algebra to dsage
  • Milestone set to sage-3.1

comment:2 Changed 5 years ago by was

  • Description modified (diff)

Changed 5 years ago by yi

Changed 5 years ago by yi

Changed 5 years ago by yi

new patch with doctests.

comment:3 follow-up: ↓ 4 Changed 5 years ago by yi

Ok, doctests are added.

comment:4 in reply to: ↑ 3 Changed 5 years ago by yi

Replying to yi:

Ok, doctests are added.

Also, be sure to remove nodoctest.py in dsage/interface. For some reason MQ doesn't pick up that I removed the file.

comment:5 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs review] implements @parallel decorator using dsage to [with patch, positive review] implements @parallel decorator using dsage

All tests pass AFTER removing nodoctest.py from sage/dsage/interface . Also, you should explicitly note the patches that this depends on (if any).

Changed 5 years ago by yi

comment:6 Changed 5 years ago by yi

dsage_interface.4.patch uses git style diffs which will remove nodoctest.py

comment:7 Changed 5 years ago by mabshoff

Yi,

could you please clarify which patches should be applied in which order? This likely also depends on some other patches to be applied first I assume in which case it would be great to note that on the ticket first, too.

Cheers,

Michael

comment:8 Changed 5 years ago by yi

Please apply dsage_interface.4.patch. It is the only one you need. Also, this patch depends on getting #3458 merged in.

comment:9 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from sage-3.1 to sage-3.0.4

Merged dsage_interface.3.patch in Sage 3.0.4.alpha1. I also removed the nodoctest manually.

Note: See TracTickets for help on using tickets.