Ticket #3421 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] MPolynomialRing_libsingular should accept longs in __call__

Reported by: malb Owned by: malb
Priority: major Milestone: sage-3.0.3
Component: commutative algebra Keywords:
Cc: burcin Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

This now works: 

sage: P.<x,y> = PolynomialRing(QQ)
sage: P("111111111111111111111111111111111111111111111111111111111")
111111111111111111111111111111111111111111111111111111111

Attachments

libsingular_longs.patch Download (2.1 KB) - added by malb 5 years ago.
updated patch to address review

Change History

comment:1 Changed 5 years ago by burcin

  • Cc burcin added; brucin removed
  • Summary changed from [with patch, needs review] MPolynomialRing_libsingular should accept longs in __call__ to [with patch, needs work] MPolynomialRing_libsingular should accept longs in __call__
  • Milestone changed from sage-3.0.4 to sage-3.0.3

This still fails on sage.math: 

sage: P("31367566080")
---------------------------------------------------------------------------
OverflowError                             Traceback (most recent call last)

/home/burcin/sage-3.0.2/<ipython console> in <module>()

/home/burcin/sage-3.0.2/multi_polynomial_libsingular.pyx in sage.rings.polynomial.multi_polynomial_libsingular.MPolynomialRing_libsingular.__call__ (sage/rings/polynomial/multi_polynomial_libsingular.cpp:4707)()

/home/burcin/sage-3.0.2/parent.pyx in sage.structure.parent.Parent._coerce_c (sage/structure/parent.c:3400)()

/home/burcin/sage-3.0.2/multi_polynomial_libsingular.pyx in sage.rings.polynomial.multi_polynomial_libsingular.MPolynomialRing_libsingular._coerce_c_impl (sage/rings/polynomial/multi_polynomial_libsingular.cpp:4283)()

OverflowError: value too large to convert to int

Changed 5 years ago by malb

updated patch to address review

comment:2 Changed 5 years ago by malb

  • Summary changed from [with patch, needs work] MPolynomialRing_libsingular should accept longs in __call__ to [with patch, needs review] MPolynomialRing_libsingular should accept longs in __call__

The updated patch addresses that bug.

comment:3 Changed 5 years ago by burcin

  • Summary changed from [with patch, needs review] MPolynomialRing_libsingular should accept longs in __call__ to [with patch, positive review] MPolynomialRing_libsingular should accept longs in __call__

Looks good to me.

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.0.3.rc0

Note: See TracTickets for help on using tickets.