Ticket #3418 (closed defect: fixed)

Opened 2 years ago

Last modified 17 months ago

[with patch, positive review] added new combinatorial functions for tableaux and crystals

Reported by: aschilling Owned by: Mike Hansen
Priority: minor Milestone: sage-3.0.3
Component: combinatorics Keywords: promotion; reflection
Cc: sage-combinat Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

I added a two new functions promotion and promotion_inverse for rectangular tableaux.

I also added a reflection operator for the crystal library.

Attachments

promotion_reflection_for_trac.patch Download (3.0 KB) - added by aschilling 2 years ago.
promotion_reflection-3418-submitted.patch Download (3.1 KB) - added by aschilling 2 years ago.
fixed the issues that Mike raised

Change History

Changed 2 years ago by aschilling

Changed 2 years ago by mhansen

  • summary changed from added new combinatorial functions for tableaux and crystals to [with patch, needs review] added new combinatorial functions for tableaux and crystals

Changed 2 years ago by mhansen

Hi Anne,

The one thing I would change is that instead of returning the string "Tableaux is not rectangular" is raising a ValueError? with that message. Also, could you add a line before "EXAMPLES" in "def s("?

Other than that, it looks good to go in.

--Mike

Changed 2 years ago by mhansen

Oh, the doctest for the ValueError? would look something like this:

sage: t = Tableau([[1,2],[2]]) 
sage: t.promotion(3) 
Traceback (most recent call last):
...
ValueError: Tableaux is not recutangular

Changed 2 years ago by aschilling

fixed the issues that Mike raised

Changed 2 years ago by mhansen

  • summary changed from [with patch, needs review] added new combinatorial functions for tableaux and crystals to [with patch, positive review] added new combinatorial functions for tableaux and crystals

Changed 2 years ago by mabshoff

  • milestone changed from sage-combinat to sage-3.0.4

Changed 2 years ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged promotion_reflection-3418-submitted.patch in Sage 3.0.3.rc0

Changed 2 years ago by mabshoff

  • milestone changed from sage-3.0.4 to sage-3.0.3

Changed 17 months ago by nthiery

  • cc sage-combinat added
Note: See TracTickets for help on using tickets.