Ticket #3407 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] better error handling for GB calculations

Reported by: malb Owned by: malb
Priority: major Milestone: sage-3.0.4
Component: commutative algebra Keywords: editor_malb
Cc: cremona, wstein, mhansen Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

  • bail out of toy_buchberger if the term ordering is unknown
  • bail out of Singular conversion if number field is relative. Singular supports this, but our conversion not just yet.

Attachments

gb_errors.patch Download (2.7 KB) - added by malb 5 years ago.

Change History

Changed 5 years ago by malb

comment:1 Changed 5 years ago by craigcitro

  • Keywords editor_malb added

comment:2 Changed 5 years ago by malb

  • Cc mhansen added

IIRC mhansen wants to review it. mhansen can you confirm or deny.

comment:3 Changed 5 years ago by mhansen

Yep -- I'll do it in the next hour.

comment:4 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs review] better error handling for GB calculations to [with patch, positive review] better error handling for GB calculations

comment:5 follow-up: ↓ 6 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, positive review] better error handling for GB calculations to [with patch, needs work] better error handling for GB calculations
  • Milestone changed from sage-3.1.1 to sage-3.0.4

I am seeing doctest failures: 

        sage -t -long devel/sage/sage/schemes/elliptic_curves/ell_point.py # 13 doctests failed
        sage -t -long devel/sage/sage/schemes/elliptic_curves/ell_generic.py # 13 doctests failed
        sage -t -long devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py # 1 doctests failed

#3406 shows issue in similar areas.

Cheers,

Michael

comment:6 in reply to: ↑ 5 Changed 5 years ago by malb

  • Summary changed from [with patch, needs work] better error handling for GB calculations to [with patch, positive review] better error handling for GB calculations

After fixing #3406. 

sage -t -long devel/sage/sage/schemes/elliptic_curves/ell_point.py
sage -t -long devel/sage/sage/schemes/elliptic_curves/ell_generic.py
sage -t -long devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py
----------------------------------------------------------------------
All tests passed!

Since this patch depends on #3406 anyway, I'll add the positive review back.

comment:7 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.0.4.alpha1

Note: See TracTickets for help on using tickets.