Ticket #3382 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] Compute Newton polytopes without polymake

Reported by: mhampton Owned by: mhansen
Priority: minor Milestone: sage-3.0.4
Component: geometry Keywords: polytope, polyhedra, polynomials, editor_mhansen
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Currently multivariable polynomials have a newton_polytope method which doesn't work without the optional polymake package installed. This patch switches this method to using the Sage-native code in geometry/polyhedra.py, which only needs the default cddlib (in the future, this might optionally use lrs as well).

Attachments

trac_3382_newton_polytope.patch Download (2.2 KB) - added by mhampton 5 years ago.

Change History

Changed 5 years ago by mhampton

comment:1 Changed 5 years ago by mabshoff

  • Summary changed from Compute Newton polytopes without polymake to [with patch, needs review] Compute Newton polytopes without polymake

comment:2 Changed 5 years ago by craigcitro

  • Keywords polynomials, editor_mhansen added; polynomials removed

comment:3 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs review] Compute Newton polytopes without polymake to [with patch, positive review] Compute Newton polytopes without polymake

Looks good and passes tests for me.

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from sage-3.1.1 to sage-3.0.4

Merged in Sage 3.0.4.alpha0

Note: See TracTickets for help on using tickets.