Ticket #3358 (new defect)

Opened 6 months ago

Last modified 3 months ago

[with new patches, needs review] Improve the building of eclib (shared/static objects)

Reported by: fbissey Assigned to: mabshoff
Priority: minor Milestone: sage-3.2.1
Component: build Keywords: editor_mabshoff
Cc: tabbott@mit.edu

Description

After sitting waiting for some answers on the last thread about this on debian-sage I decided to go ahead. This patch do not add versionning for debian as it seems to cause problem on other OS. It builds static objects (libraries and executables) without any pic flag and shared object with pic flag on linux. I respected the earlier setting where the flag is set in spkg-install and it is set to nothing on OS X and CYGWIN although I think it should be set as well on this platform. I also move executables in a created bin directory for convenience (this directory is created by the Makefile). I cleaned the spkg-install to accommodate the changes and added a few fix that I thought necessary. -fPIC to -fpic, those are 2 slightly different flags, I don't think I should go on the technical differences between them. I also cleaned a conditional block were linux specific code would be executed on darwin - probably without harm but still.

Attachments

eclib-so.patch (11.7 kB) - added by fbissey on 06/03/2008 04:58:25 PM.
eclib_spkg-install.patch (1.9 kB) - added by fbissey on 06/03/2008 04:58:43 PM.
eclib-spkg-install.patch (1.5 kB) - added by fbissey on 07/08/2008 03:33:22 PM.
update spkg-install to use the bin folder
eclib-ungnu.patch (121.8 kB) - added by fbissey on 07/10/2008 02:43:57 PM.
ungnu-ify the makefiles [update to correct a small typo]

Change History

06/03/2008 04:58:25 PM changed by fbissey

  • attachment eclib-so.patch added.

06/03/2008 04:58:43 PM changed by fbissey

  • attachment eclib_spkg-install.patch added.

06/03/2008 06:33:52 PM changed by fbissey

  • cc set to tabbott@mit.edu.

06/15/2008 03:01:50 PM changed by craigcitro

  • keywords set to editor_mabshoff.

06/15/2008 03:02:27 PM changed by craigcitro

  • summary changed from Improve the building of eclib (shared/static objects) [with patch needs review] to [with patch, needs review] Improve the building of eclib (shared/static objects).

Please remember to put the "[with patch, needs review]" at the *beginning* of the summary.

06/19/2008 09:02:29 PM changed by mabshoff

  • summary changed from [with patch, needs review] Improve the building of eclib (shared/static objects) to [with patch, mixed review] Improve the building of eclib (shared/static objects).

I do not like the "-fPIC" -> "-fpic" change, otherwise I am fine with the patch.

Cheers,

Michael

06/20/2008 01:03:08 AM changed by fbissey

Hi Michael,

I didn't think you would take it anyway as it has GNU-ism like: (SO_LIBNAME): FPICFLAG= $(PICFLAG)

export FPICFLAG

I thought a bit more about -fPIC versus -fPIC and I guess in the interest of KISS we should probably stick to -fPIC as ppc and may be other may balk otherwise.

07/06/2008 06:19:54 PM changed by fbissey

  • summary changed from [with patch, mixed review] Improve the building of eclib (shared/static objects) to [with new patches, needs review] Improve the building of eclib (shared/static objects).

OK new patches to ungnu-ify the makefiles and build shared and static objects properly and use the bin folder. Tested with bsd make and gnu make - didn't have time for sun make, should work though. spkg-install also updated. everything is against eclib-20080310.p4

07/08/2008 03:33:22 PM changed by fbissey

  • attachment eclib-spkg-install.patch added.

update spkg-install to use the bin folder

07/08/2008 03:34:24 PM changed by fbissey

updated the patches to 20080310.p5.

07/10/2008 02:43:57 PM changed by fbissey

  • attachment eclib-ungnu.patch added.

ungnu-ify the makefiles [update to correct a small typo]

08/10/2008 09:23:39 AM changed by cremona

I'm probably not the best person to review this but if there's anything I can do, please let me know. John