Ticket #3304 (closed enhancement: fixed)

Opened 5 years ago

Last modified 3 years ago

Make cddlib a shared library

Reported by: tabbott Owned by: tabbott
Priority: major Milestone: sage-4.4.3
Component: debian-package Keywords: editor_mabshoff
Cc: vbraun, mhampton Work issues:
Report Upstream: N/A Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by vbraun) (diff)

Cddlib builds as a static library only. We should libtoolize it so that it installs static and dynamic libraries and .la files.

Attachments

cddlib-debian-shared-library.patch Download (301.6 KB) - added by tabbott 5 years ago.
cddlib-shared-library.patch Download (284.9 KB) - added by tabbott 4 years ago.

Change History

Changed 5 years ago by tabbott

comment:1 Changed 5 years ago by craigcitro

  • Keywords editor_mabshoff added

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from [with patch; needs review] Make cddlib Debian package use shared library to [with patch; needs review, waiting on upstream] Make cddlib Debian package use shared library

comment:3 Changed 5 years ago by craigcitro

  • Summary changed from [with patch; needs review, waiting on upstream] Make cddlib Debian package use shared library to [with patch, waiting on upstream] Make cddlib Debian package use shared library

Changed 4 years ago by tabbott

comment:4 Changed 4 years ago by tabbott

Earlier today I attached a version of the patch that doesn't mess with dist/debian (since that's no longer relevant).

comment:5 Changed 4 years ago by mabshoff

  • Priority changed from blocker to critical

Well, given how long we have been sitting on this reduce priority to critical.

Cheers,

Michael

comment:6 Changed 3 years ago by vbraun

  • Status changed from needs_work to needs_review
  • Description modified (diff)
  • Cc vbraun, mhampton added
  • Summary changed from [with patch, waiting on upstream] Make cddlib Debian package use shared library to [with patch, needs review] Make cddlib a shared library
  • Priority changed from critical to major
  • Report Upstream set to N/A

Has nothing to do with Debian, maybe that was misleading; summary changed.

The following spkg is patched in a similar way. It essentially contains tabbott's patch, but I found this report only after making the changes myself.

 http://www.stp.dias.ie/~vbraun/cddlib-094f.p3.spkg

Users of the Fedora 12 binary sage distribution must manually re-install mpir-1.2.2.p0.spkg as discussed on  http://groups.google.com/group/sage-devel/msg/aec4aa6b3874fe10. This is an unrelated bug of the build system.

comment:7 Changed 3 years ago by vbraun

Superseded by #8115

comment:8 Changed 3 years ago by was 

As I understand,

http://trac.sagemath.org/sage_trac/ticket/3304

should be just closed, not reviewed, since another ticket took care of
the issue.

Since only release managers should close tickets, I am leaving the
ticket as is and posting here.

Thank you,
Andrey

comment:9 Changed 3 years ago by was

  • Status changed from needs_review to closed
  • Resolution set to fixed

comment:10 Changed 3 years ago by mvngu

  • Summary changed from [with patch, needs review] Make cddlib a shared library to Make cddlib a shared library
Note: See TracTickets for help on using tickets.