Ticket #3243 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch; positive review] cygwin -- get it to work on cygwin

Reported by: was Owned by: mabshoff
Priority: major Milestone: sage-3.0.2
Component: porting: Cygwin Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Wrap log2 in a function so it will work in cygwin. In cygwin log2 is a macro: 

sh-3.2$ grep log2 *.h
math.h:#define log2(x) (log (x) / M_LOG2_E)
math.h:#define log2f(x) (logf (x) / (float) M_LOG2_E)

Attachments

sage-3243.patch Download (1005 bytes) - added by was 5 years ago.

Change History

Changed 5 years ago by was

comment:1 Changed 5 years ago by mabshoff

The same issue pops up on Solaris 9. Solaris 10 is fine.

Cheers,

Michael

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from [with patch; needs review] cygwin -- get it to work on cygwin to [with patch; positive review] cygwin -- get it to work on cygwin

Patch is good, positive review. With the patch applied doctests pass.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.0.2.alpha1

Note: See TracTickets for help on using tickets.