Ticket #3223 (closed defect: fixed)

Opened 22 months ago

Last modified 16 months ago

[with patch; positive review] notebook -- it is now broken on the iphone

Reported by: was Owned by: boothby
Priority: blocker Milestone: sage-3.2
Component: notebook Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

Now I think left or right parenthesis sends carriage return. I think this likely has something to do with updating the keyboard support for the new safari browser.

Attachments

sage-3223.patch Download (1.4 KB) - added by was 16 months ago.

Change History

Changed 16 months ago by was

Changed 16 months ago by was

  • summary changed from notebook -- it is now broken on the iphone to [with patch; needs review] notebook -- it is now broken on the iphone

I fixed this by disabling *all* keyboard shortcut handling on the iphone. This is a good idea, since the iphone does not have any of the keys needed to send any of the keyboard shortcuts, and it gets around the problem.

To referee this 3-line patch, just verify that clearly I didn't break anything, since all I did was add a special case to check for the iphone string in the browser UA tag, and only then disable keyboard shortcut handling.

Changed 16 months ago by was

  • milestone changed from sage-3.2.1 to sage-3.2

I'm moving this back to 3.2. It's harmless (famous last words), and I really think having iphone support working again is an extremely important bug fix.

Changed 16 months ago by boothby

  • summary changed from [with patch; needs review] notebook -- it is now broken on the iphone to [with patch; positive review] notebook -- it is now broken on the iphone

+1

Changed 16 months ago by was

  • priority changed from major to blocker

Changed 16 months ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in Sage 3.2.rc2

Note: See TracTickets for help on using tickets.