Ticket #3213 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] notebook -- Account Settings page for changing password and e-mail address

Reported by: TimothyClemans Owned by: boothby
Priority: major Milestone: sage-3.0.2
Component: notebook Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description


Attachments

3213.patch Download (6.3 KB) - added by TimothyClemans 5 years ago.
I used sage-3.0.1 and applied  http://sage.math.washington.edu/home/was/patches/bugday12.hg

Change History

Changed 5 years ago by TimothyClemans

comment:1 Changed 5 years ago by TimothyClemans

  • Summary changed from notebook -- Account Settings page for changing password and e-mail address to [with patch, needs review] notebook -- Account Settings page for changing password and e-mail address

comment:2 Changed 5 years ago by was

  • Summary changed from [with patch, needs review] notebook -- Account Settings page for changing password and e-mail address to [with patch, positive review] notebook -- Account Settings page for changing password and e-mail address

REVIEW:

I think the code looks fine and this should be applied.

I think the settings panel itself has a lot of work until it is the ultimate settings panel, etc. But this is a very good start, and additional work should simply go in another patch. Some comments for future work:

  • Instead of "Cancel" being the only way to leave the settings page, how about a "Save" button that saves all changes, and a "cancel" button that throws away all changes?
  • Currently changes are still saved even if you click cancel.
  • Make the thing a little more stylish.

Please do these as a separate ticket from this ticket, since I want #3213 to get in as is.

This patch I think depends on Tim's other patch for "changing the password".

-- William

comment:3 Changed 5 years ago by TimothyClemans

Follow up ticket with patch needing review is #3228.

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.0.2.alpha1

Note: See TracTickets for help on using tickets.