Ticket #3160 (closed defect: fixed)
[with patch, positive review] change is_planar for graphs to return bool
| Reported by: | was | Owned by: | rlm |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.0.2 |
| Component: | graph theory | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
+1 on making this change. It's very unusual for an is_ function to return anything but a bool :) - Hide quoted text - On Sun, May 11, 2008 at 11:34 AM, Robert Miller <rlmillster@gmail.com> wrote: > >> On the other hand, that Jerin was confused maybe strongly suggests >> you might want to change the is_planar function to return True or >> False, and have another function or a flag to get the nonplanar >> subgroup. In most of Sage foo.is_*() returns True or False, so maybe >> is_planar() is confusing, especially from a readability point of view. > > I think I agree. The default behavior should be True/False, and an > option to return the present tuple should be available. > >
Attachments
Change History
comment:1 Changed 5 years ago by ekirkman
- Summary changed from change is_planar for graphs to return bool to [with patch, needs review] change is_planar for graphs to return bool
Note: See
TracTickets for help on using
tickets.

