Ticket #3108 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

[with patch, positive review] implement additive_order for elliptic curve points

Reported by: was Owned by: davidloeffler
Priority: major Milestone: sage-4.1.2
Component: elliptic curves Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Chris Wuthrich
Authors: John Cremona Merged in: Sage 4.1.2.alpha0
Dependencies: Stopgaps:

Description 

sage: E = EllipticCurve(GF(5),[1..5])
sage: P = E.lift_x(0)
sage: P
(0 : 2 : 1)
sage: P.additive_order()
---------------------------------------------------------------------------
<type 'exceptions.NotImplementedError'>   Traceback (most recent call last)

/Users/was/papers/submitted/kolyconj/<ipython console> in <module>()

/Users/was/papers/submitted/kolyconj/element.pyx in sage.structure.element.ModuleElement.additive_order()

<type 'exceptions.NotImplementedError'>: 
sage: P.order()
3

Attachments

trac_3108-additive_order.patch Download (2.7 KB) - added by cremona 4 years ago.

Change History

comment:1 Changed 5 years ago by was

  • Type changed from defect to enhancement

comment:2 Changed 4 years ago by davidloeffler

  • Owner changed from was to davidloeffler
  • Component changed from number theory to elliptic curves

Changed 4 years ago by cremona

comment:3 Changed 4 years ago by cremona

  • Authors set to John Cremona

Done: I defined additive_order to be a synonym for order (in 3 places) with relevant doctests.

comment:4 Changed 4 years ago by cremona

  • Summary changed from implement additive_order for elliptic curve points to [with patch, needs review] implement additive_order for elliptic curve points

comment:5 Changed 4 years ago by wuthrich

  • Summary changed from [with patch, needs review] implement additive_order for elliptic curve points to [with patch, positive review] implement additive_order for elliptic curve points

Fine.

Maybe David Loeffler, working on abelian groups, wants this differently. By now, this should go in.

chris.

comment:6 Changed 4 years ago by mvngu

  • Status changed from new to closed
  • Reviewers set to Chris Wuthrich
  • Resolution set to fixed
  • Merged in set to Sage 4.1.2.alpha0
Note: See TracTickets for help on using tickets.