Ticket #3101 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] pbuild: mwrank.so needs to be build as a C++ extension

Reported by: mabshoff Owned by: gfurnish
Priority: blocker Milestone: sage-3.0.1
Component: pbuild Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Some people have reported mwrank.so missing some symbols at startup when compiled with pbuild, but the old build system is fine.

Working: 

g++ -pthread -shared build/temp.linux-x86_64-2.5/sage/libs/mwrank/mwrank.o 
build/temp.linux-x86_64-2.5/sage/libs/mwrank/wrap.o -L/scratch/mabshoff/
release-cycle/sage-3.0.1.final/local//lib -lcsage -lcurvesntl -lg0nntl 
-ljcntl -lrankntl -lntl -lgmp -lgmpxx -lstdc++ -lm -lpari -lstdc++ -lntl 
-o build/lib.linux-x86_64-2.5/sage/libs/mwrank/mwrank.so

Non-working: 

gcc -O3 -g -fwrapv -shared -fno-strict-aliasing /mnt/drive_hda1/sagefiles/
sage-3.0.1.rc0/devel/sage/build/temp/sage/libs/mwrank/mwrank.o -L/home/wdj/
wdj/sagefiles/sage-3.0.1.rc0/local/lib  -lcsage  -lcurvesntl  -lg0nntl  
-ljcntl  -lrankntl  -lntl -lgmp  -lgmpxx  -lstdc++  -lm  -lpari  -lstdc++  
-lntl  -o /mnt/drive_hda1/sagefiles/sage-3.0.1.rc0/devel/sage-main/build/
sage/libs/mwrank/mwrank.so

mwrank.so is a C wrapper around a C++ extension, so on some systems the linker ends up either being stupid or clever depending on your perspective.

Cheers,

Michael

Attachments

trac_extcode_3101.patch Download (2.0 KB) - added by gfurnish 5 years ago.

Change History

Changed 5 years ago by gfurnish

comment:1 Changed 5 years ago by gfurnish

  • Status changed from new to assigned
  • Summary changed from pbuild: mwrank.so needs to be build as a C++ extension to [with patch, needs review]pbuild: mwrank.so needs to be build as a C++ extension

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, needs review]pbuild: mwrank.so needs to be build as a C++ extension to [with patch, positive review] pbuild: mwrank.so needs to be build as a C++ extension

Patch looks good to me.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.0.1.final

comment:4 Changed 5 years ago by mabshoff

  • Milestone changed from sage-3.0.2 to sage-3.0.1
Note: See TracTickets for help on using tickets.