Ticket #3097 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[with patch, positive review] pbuild: make sure the files from setup.py's scripts section are copied

Reported by: mabshoff Owned by: gfurnish
Priority: blocker Milestone: sage-3.0.2
Component: pbuild Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

If one uses pbuild to build the Sage library the files from the scripts section are not copied into $SAGE_ROOT/local/bin: 

      scripts = ['sage/dsage/scripts/dsage_worker.py',
                 'sage/dsage/scripts/dsage_setup.py',
                 'spkg-debian-maybe',
                ],

Ergo DSage's doctest just hang at 0% CPU use.

Cheers,

Michael

Attachments

trac_3097.patch Download (44.4 KB) - added by gfurnish 2 years ago.
trac_3097_scripts.patch Download (43.7 KB) - added by gfurnish 2 years ago.
trac_3097-hgignore.patch Download (506 bytes) - added by mabshoff 2 years ago.
trac_3097-sdist-fix.patch Download (0.7 KB) - added by mabshoff 2 years ago.
trac_3097_extcode.patch Download (3.2 KB) - added by mabshoff 2 years ago.
this is a slightly updated version of the original patch by Gary
trac_3097-sdist-fix-part2.patch Download (0.7 KB) - added by mabshoff 2 years ago.
oops - this ought to fix the issue

Change History

Changed 2 years ago by mabshoff

  • priority changed from major to blocker

Changed 2 years ago by mabshoff

  • owner changed from mabshoff to gfurnish
  • component changed from build to pbuild

Changed 2 years ago by gfurnish

Changed 2 years ago by gfurnish

Changed 2 years ago by gfurnish

  • status changed from new to assigned
  • summary changed from pbuild: make sure the files from setup.py's scripts section are copied to [with patch, needs review] pbuild: make sure the files from setup.py's scripts section are copied

Changed 2 years ago by mabshoff

  • summary changed from [with patch, needs review] pbuild: make sure the files from setup.py's scripts section are copied to [with patch, negative review] pbuild: make sure the files from setup.py's scripts section are copied

The patches will not work as is:

  • this patchset, especially the bit to setup.py will break slowbuild
  • the scripts repo will be broken once you -sdist
  • what happens on clone

This is as-is not going into 3.0.1 :(.

Cheers,

Michael

Changed 2 years ago by gfurnish

1) The patchset should not break slowbuild (infact the change to slowbuild should fix it for the scripts repo). 2) I don't understand why -sdist is going to break the scripts repo. I added the files to the hg scripts repo, why will sdist break this? 3) the dsage/web directory is a link to devel/sage/...... so it will keep pointing at the right target on clone.

Changed 2 years ago by yi

I haven't been able to test this set of patches yet but from speaking with gfurnish on IRC it seems to be the right way to go to resolve the pbuild issue. I'll try these patches out and provide feedback then.

Changed 2 years ago by mabshoff

  • milestone changed from sage-3.0.3 to sage-3.0.2

Changed 2 years ago by mabshoff

Changed 2 years ago by mabshoff

Changed 2 years ago by mabshoff

this is a slightly updated version of the original patch by Gary

Changed 2 years ago by mabshoff

oops - this ought to fix the issue

Changed 2 years ago by mabshoff

  • summary changed from [with patch, negative review] pbuild: make sure the files from setup.py's scripts section are copied to [with patch, positive review] pbuild: make sure the files from setup.py's scripts section are copied

Ok, now the -sdist issue is resolved. I did an sdist followed by a full rebuild and a testall. Positive review.

Cheers,

Michael

Changed 2 years ago by mabshoff

  • status changed from assigned to closed
  • resolution set to fixed

Merged all six patches in Sage 3.0.2.rc0

Note: See TracTickets for help on using tickets.