Ticket #3068 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

empty matrices: smith_form() throws a RuntimeError

Reported by: dfdeshom Owned by: was
Priority: major Milestone: sage-3.2.2
Component: linear algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

sage: m = matrix([])
sage: m.smith_form()
<type 'exceptions.RuntimeError'>:

Change History

comment:1 Changed 5 years ago by dfdeshom

This seems to be gone as of 3.1.1. Could someone close this? 

sage: m = matrix([])
sage: m.smith_form()
 ([], [], [])

comment:2 Changed 4 years ago by davidloeffler

  • Status changed from new to closed
  • Resolution set to fixed

In 3.2.2.alpha0 this works fine as long as the matrix has 0 rows and 0 columns, but for 0 rows and a nonzero number of columns (or vice versa) we still get the error. This arises from the fact that Pari doesn't have the notion of a matrix with 0 rows and 1 column, so the matrix gets "truncated" (!) before being passed to Pari.

I will fix this as part of #4681.

comment:3 Changed 4 years ago by mabshoff

  • Status changed from closed to reopened
  • Resolution fixed deleted

Hi David,

usually the release manager does the closing of a ticket once the fix has been merged. Until then it stays open.

Cheers,

Michael

comment:4 follow-up: ↓ 5 Changed 4 years ago by davidloeffler

I'm sorry for overstepping my authority. Anyway, the fix is now up at #4681.

comment:5 in reply to: ↑ 4 Changed 4 years ago by mabshoff

Replying to davidloeffler:

I'm sorry for overstepping my authority. Anyway, the fix is now up at #4681.

Don't worry about it because it is one of those unwritten rules :)

Cheers,

Michael

comment:6 Changed 4 years ago by mabshoff

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed in Sage 3.2.2.alpha1 via #4681.

Cheers,

Michael

Note: See TracTickets for help on using tickets.