Ticket #3044 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] phcpack improvements: path tracking

Reported by: mhampton Owned by: somebody
Priority: minor Milestone: sage-3.0.4
Component: numerical Keywords: phcpack, interfaces, optional packages, editor_cwitty
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

I (Marshall Hampton) and Alex Jokela have added a number of improvements to the phcpack interface, including solution classification, path-tracking, and some utility functions. This also includes much better doctesting.

Attachments

trac_3044_phcpack.patch Download (37.7 KB) - added by mhampton 5 years ago.
phcpack-optional.patch Download (808 bytes) - added by cwitty 5 years ago.

Change History

comment:1 Changed 5 years ago by mhampton

  • Keywords phcpack, interfaces, optional packages added

Changed 5 years ago by mhampton

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from phcpack improvements: path tracking to [with patch, needs review] phcpack improvements: path tracking
  • Milestone set to sage-3.0.1

comment:3 Changed 5 years ago by mhampton

  • Owner changed from jkantor to somebody

comment:4 Changed 5 years ago by craigcitro

  • Keywords packages, editor_cwitty added; packages removed

Changed 5 years ago by cwitty

comment:5 Changed 5 years ago by cwitty

  • Summary changed from [with patch, needs review] phcpack improvements: path tracking to [with patch, positive review] phcpack improvements: path tracking

Looks good! Doctests pass with phc installed; the plot looks pretty; and after applying my phcpack-optional.patch, doctests pass without phc installed.

comment:6 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged both patches in Sage 3.0.4.alpha0

comment:7 Changed 5 years ago by mabshoff

  • Milestone changed from sage-3.1.1 to sage-3.0.4
Note: See TracTickets for help on using tickets.