Ticket #3029 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch; positive review] Move DEB_AUTO_UPDATE_DEBIAN_CONTROL out of Debian packages

Reported by: tabbott Owned by: tabbott
Priority: major Milestone: sage-3.0.1
Component: debian-package Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by mabshoff) (diff)

Debian doesn't allow you to upload packages that use DEB_AUTO_UPDATE_DEBIAN_CONTROL because it causes confusion with Non-Maintainer Uploads. Since I'd like to get the packages so that they can be uploaded to Debian, we should remove it from our rules files. Since it's fine for our purposes, I've modified sage-debsource to set DEB_AUTO_UPDATE_DEBIAN_CONTROL so that it always gets used when we are building packages. I think it's probably easier for Michael to just make the changes than to merge N patches, so the following code will do the relevant update when the relevant spkgs are unpacked.

perl -i -0pe 's/^DEB_AUTO_UPDATE_DEBIAN_CONTROL = 1\n//m' 
*/dist/debian/*/rules */dist/debian/rules

(if the patches are easier to deal with, let me know and I'll generate them) The complete list of spkgs that require this treatment is as follows:

  • cddlib
  • eclib
  • extcode
  • flint
  • flintqs
  • gap
  • genus2reduction
  • gfan
  • givaro
  • iml
  • jmol
  • lcalc
  • libfplll
  • libm4ri
  • linbox
  • ntl
  • palp
  • polybori
  • rubiks
  • scipy_sandbox
  • singular
  • symmetrica
  • sympow
  • tachyon
  • zn_poly

Attachments

auto-update-debian-control.patch Download (671 bytes) - added by tabbott 5 years ago.
auto-cddlib.patch Download (591 bytes) - added by tabbott 5 years ago.
auto-extcode.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-flint.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-flintqs.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-genus.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-gfan.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-givaro.patch Download (642 bytes) - added by tabbott 5 years ago.
auto-iml.patch Download (591 bytes) - added by tabbott 5 years ago.
auto-jmol.patch Download (603 bytes) - added by tabbott 5 years ago.
auto-libfplll.patch Download (591 bytes) - added by tabbott 5 years ago.
auto-libm4ri.patch Download (642 bytes) - added by tabbott 5 years ago.
auto-linbox.patch Download (1.2 KB) - added by tabbott 5 years ago.
auto-palp.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-rubiks.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-singular.patch Download (640 bytes) - added by tabbott 5 years ago.
auto-symmetr.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-sympow.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-tachyon.patch Download (608 bytes) - added by tabbott 5 years ago.
auto-zn_pol.patch Download (609 bytes) - added by tabbott 5 years ago.
auto-scipy_sandbox.patch Download (1.0 KB) - added by tabbott 5 years ago.
auto-ntl.patch Download (1.4 KB) - added by tabbott 5 years ago.
auto-polybori.patch Download (593 bytes) - added by tabbott 5 years ago.
auto-gap.patch Download (647 bytes) - added by tabbott 5 years ago.

Change History

Changed 5 years ago by tabbott

comment:1 Changed 5 years ago by mabshoff

  • Description modified (diff)

comment:2 Changed 5 years ago by mabshoff

  • Description modified (diff)

comment:3 Changed 5 years ago by mabshoff

Hi Tim,

do I still need to run the perl script if I apply the patches? I would prefer to import 25 patches since then I do have a record. Since I will likely touch a lot of the spkgs in the next two days for cleanups I think it will be fine if you post those 25 patches and I just merge them as I go.

Cheers,

Michael

comment:4 Changed 5 years ago by tabbott

No, the perl script is what generates the patches that need to be done (there's also a single patch not done by the perl script that I've already uploaded). I'll go ahead and post the 25 patches, then.

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

Changed 5 years ago by tabbott

comment:5 Changed 5 years ago by mabshoff

  • Summary changed from [with patch; needs review] Move DEB_AUTO_UPDATE_DEBIAN_CONTROL out of Debian packages to [with patch; positive review] Move DEB_AUTO_UPDATE_DEBIAN_CONTROL out of Debian packages

The patches look good to me. Most of them are really trivial, the two, three others are fine, too. I put them into the spkgs without bumping the patch level to avoid massive recompile on update.

Please, no more massive 25 spkg patch orgies ;)

Cheers,

Michael

comment:6 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.0.1.alpha1

Note: See TracTickets for help on using tickets.