Ticket #3029 (closed defect: fixed)
[with patch; positive review] Move DEB_AUTO_UPDATE_DEBIAN_CONTROL out of Debian packages
| Reported by: | tabbott | Owned by: | tabbott |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.0.1 |
| Component: | debian-package | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description (last modified by mabshoff) (diff)
Debian doesn't allow you to upload packages that use DEB_AUTO_UPDATE_DEBIAN_CONTROL because it causes confusion with Non-Maintainer Uploads. Since I'd like to get the packages so that they can be uploaded to Debian, we should remove it from our rules files. Since it's fine for our purposes, I've modified sage-debsource to set DEB_AUTO_UPDATE_DEBIAN_CONTROL so that it always gets used when we are building packages. I think it's probably easier for Michael to just make the changes than to merge N patches, so the following code will do the relevant update when the relevant spkgs are unpacked.
perl -i -0pe 's/^DEB_AUTO_UPDATE_DEBIAN_CONTROL = 1\n//m' */dist/debian/*/rules */dist/debian/rules
(if the patches are easier to deal with, let me know and I'll generate them) The complete list of spkgs that require this treatment is as follows:
- cddlib
- eclib
- extcode
- flint
- flintqs
- gap
- genus2reduction
- gfan
- givaro
- iml
- jmol
- lcalc
- libfplll
- libm4ri
- linbox
- ntl
- palp
- polybori
- rubiks
- scipy_sandbox
- singular
- symmetrica
- sympow
- tachyon
- zn_poly
Attachments
Change History
comment:3 Changed 5 years ago by mabshoff
Hi Tim,
do I still need to run the perl script if I apply the patches? I would prefer to import 25 patches since then I do have a record. Since I will likely touch a lot of the spkgs in the next two days for cleanups I think it will be fine if you post those 25 patches and I just merge them as I go.
Cheers,
Michael
comment:4 Changed 5 years ago by tabbott
No, the perl script is what generates the patches that need to be done (there's also a single patch not done by the perl script that I've already uploaded). I'll go ahead and post the 25 patches, then.
comment:5 Changed 5 years ago by mabshoff
- Summary changed from [with patch; needs review] Move DEB_AUTO_UPDATE_DEBIAN_CONTROL out of Debian packages to [with patch; positive review] Move DEB_AUTO_UPDATE_DEBIAN_CONTROL out of Debian packages
The patches look good to me. Most of them are really trivial, the two, three others are fine, too. I put them into the spkgs without bumping the patch level to avoid massive recompile on update.
Please, no more massive 25 spkg patch orgies ;)
Cheers,
Michael

