Ticket #2988 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch; emphatic positive review] notebook -- issues with the CSS for the print display

Reported by: was Owned by: boothby
Priority: blocker Milestone: sage-3.0
Component: notebook Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Mabshoff -- sorry I have to put this in as a 3.0 block (and fix it now). It won't affect anything doctested. I've had several professors (including me!) complain about issues with the notebook css and printing. And, I told them I would fix this for 3.0.

Attachments

sage-2988.patch Download (3.6 KB) - added by was 5 years ago.
sage-2988_rebased.patch Download (3.6 KB) - added by was 5 years ago.

Change History

comment:1 Changed 5 years ago by was

  • Summary changed from notebook -- issues with the CSS for the print display to [with patch; needs review] notebook -- issues with the CSS for the print display

Changed 5 years ago by was

comment:2 Changed 5 years ago by boothby

  • Summary changed from [with patch; needs review] notebook -- issues with the CSS for the print display to [with patch; emphatic positive review] notebook -- issues with the CSS for the print display

Excellent!

comment:3 Changed 5 years ago by mabshoff

It doesn't apply cleanly against rc1: 

sage@modular:~/build/sage-3.0.rc1/devel/sage$ hg import /home2/mabshoff/trac_2988.patch
applying /home2/mabshoff/trac_2988.patch
patching file sage/server/notebook/cell.py
Hunk #1 FAILED at 645
1 out of 2 hunks FAILED -- saving rejects to file sage/server/notebook/cell.py.rej
abort: patch failed to apply

Cheers,

Michael

Changed 5 years ago by was

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged sage-2988_rebased.patch in Sage 3.0.final

Note: See TracTickets for help on using tickets.