Ticket #2964 (closed enhancement: fixed)

Opened 2 years ago

Last modified 17 months ago

[with patch, positive review] Improvements to weyl_group.py

Reported by: bump Owned by: mhansen
Priority: minor Milestone: sage-3.0
Component: combinatorics Keywords:
Cc: sage-combinat Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

WeylGroup? gets a proper call method that produces a WeylGroup? element. Previously if G is a Weyl group then G(m) produced a MatrixRing? element. This part is a bugfix.

Root systems get a method to produce the highest root, relevant to the affine root system. This could be implemented as a case-by-case method and that would be faster, but searching through the roots for the highest weight is of acceptable speed.

Weyl Groups get a method to produce the long element of the Weyl group. Not implemented yet for E7 and E8.

Weyl group also gets a method to produce the identity element as a WeylGroup? element. Strictly speaking this is not necessary since W(1) will also produce the unit.

Attachments

9564.patch Download (7.0 KB) - added by bump 2 years ago.
9565.patch Download (0.9 KB) - added by bump 2 years ago.
9566.patch Download (1.1 KB) - added by bump 2 years ago.
2964-review.patch Download (1.9 KB) - added by mhansen 2 years ago.

Change History

Changed 2 years ago by bump

Changed 2 years ago by bump

Changed 2 years ago by bump

These are patches against 3.0alpha6.

Changed 2 years ago by mabshoff

  • summary changed from Improvements to weyl_group.py to [with patch, needs review] Improvements to weyl_group.py

Changed 2 years ago by bump

There will be a further patch because I forgot to finish the doctests.

Changed 2 years ago by mhansen

Okay, excellent. I'll review them when you put them up.

Changed 2 years ago by bump

Changed 2 years ago by bump

I added a third patch with doctest for long element and now I think it is OK.

Thanks, Dan

Changed 2 years ago by mhansen

Changed 2 years ago by mhansen

  • summary changed from [with patch, needs review] Improvements to weyl_group.py to [with patch, positive review] Improvements to weyl_group.py

Looks good to me. Apply all four patches.

Changed 2 years ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged all four patches in Sage 3.0.rc0

Changed 17 months ago by nthiery

  • cc sage-combinat added
Note: See TracTickets for help on using tickets.