Ticket #2868 (closed defect: fixed)

Opened 2 years ago

Last modified 11 months ago

[with patch, positive review] Weight revision for fastcrystals

Reported by: bump Owned by: mhansen
Priority: minor Milestone: sage-3.0
Component: combinatorics Keywords:
Cc: sage-combinat Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

This extends the revision of the patch in:

 http://sagetrac.org/sage_trac/ticket/2853

The previous patch reimplemented the weight function for vertices in crystals of letters and crystals of tableaux. The patch at hand does the corresponding reimplementation for fastcrystals. These are crystals whose definition is limited to types A2, B2, C2. They are isomorphic to crystals of tableaux but have better speed when the crystal is large, since the root operators are implemented by table lookup.

The revised weight function should be very fast since the weight is computed by adding a few numbers together.

This patch corrects the same defect for type A2 that the previous patch addressed.

The tests in the patch were written BEFORE the weight function was reimplemented, so I am confident that it is correct.

Attachments

weight_fastcrystal.patch Download (3.0 KB) - added by bump 2 years ago.
2868.patch Download (3.0 KB) - added by mhansen 2 years ago.

Change History

Changed 2 years ago by bump

Changed 2 years ago by bump

  • owner changed from mhansen to bump
  • status changed from new to assigned

Changed 2 years ago by bump

  • milestone set to sage-3.0

Changed 2 years ago by bump

  • owner changed from bump to mhansen
  • status changed from assigned to new

Changed 2 years ago by mabshoff

  • summary changed from Weight revision for fastcrystals to [with patch, needs review] Weight revision for fastcrystals

Changed 2 years ago by mhansen

Changed 2 years ago by mhansen

  • status changed from new to assigned
  • summary changed from [with patch, needs review] Weight revision for fastcrystals to [with patch, positive review] Weight revision for fastcrystals

I attached a new patch which removes a print statement and moves the tests down to the docstring of weight.

Changed 2 years ago by mabshoff

  • status changed from assigned to closed
  • resolution set to fixed

Merged 2868.patch in Sage 3.0.alpha4

Changed 11 months ago by nthiery

  • cc sage-combinat added
Note: See TracTickets for help on using tickets.