Ticket #2852 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[with patch, positive review] ctrl-enter broken in firefox/linux

Reported by: boothby Owned by: boothby
Priority: major Milestone: sage-3.0
Component: notebook Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description


Attachments

2852-keyfixes.patch Download (1.8 KB) - added by boothby 2 years ago.

Change History

Changed 2 years ago by boothby

Changed 2 years ago by boothby

  • summary changed from ctrl-enter broken in firefox/linux to [with patch, needs review] ctrl-enter broken in firefox/linux

The attached should be approached with distrust. It makes a very low-level change to how key events are handled. Test all keycodes in all browsers before and after applying this patch.

Changed 2 years ago by was

  • summary changed from [with patch, needs review] ctrl-enter broken in firefox/linux to [with patch, positive review] ctrl-enter broken in firefox/linux

It looks good to me. I'm going to test the heck out of the notebook before 3.0 is released anyways, so I say we apply this.

NOTE: I updated a comment that should be updated because of this patch, but that will go in a subsequent "fix of a few small bugs" notebook patch I'll post shortly.

Changed 2 years ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in Sage 3.0.alpha3

Note: See TracTickets for help on using tickets.