Ticket #2798 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] probably easy-to-fix ptest issue

Reported by: was Owned by: gfurnish
Priority: major Milestone: sage-3.0
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

09:56 < wstein> I just got this from ptest:
09:56 -!- Irssi: Pasting 5 lines to #sage-devel. Press Ctrl-K if you wish to do this or Ctrl-C to cancel.
09:56 < wstein>   File "/Users/was/build/sage-2.10.4/local/bin/sage-ptest", line 74, in run
09:56 < wstein>     if e==-2:
09:56 < wstein> UnboundLocalError: local variable 'e' referenced before assignment
09:56 < wstein>  
09:56 < wstein> but then it worked...

Attachments

trac_2798.patch Download (818 bytes) - added by gfurnish 5 years ago.

Change History

Changed 5 years ago by gfurnish

comment:1 Changed 5 years ago by gfurnish

  • Status changed from new to assigned

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from probably easy-to-fix ptest issue to [with patch, positive review] probably easy-to-fix ptest issue

Patch looks good to me. It doesn't really address the issue wstein encountered, but it will print a proper error message the next time somebody hits the bug that caused the problem in the first place. Positive review.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.0.alpha1

Note: See TracTickets for help on using tickets.