Ticket #2736 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[with patch, positive review] fix for dsage doctest failures in sage-2.11.rc0

Reported by: yi Owned by: yi
Priority: major Milestone: sage-2.11
Component: dsage Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

Attached is a patch which fixes the annoying exceptions thrown by the doctest runner at the end of the dsage doctests.

This patch does the following: 1) Explicitly call .wait() on subprocess.Popen instances 2) Explicitly delete the reference to the Popen instances before letting the interpreter exit 3) Explicitly join the dsage thread before letting the interpreter exit in the doctest.

Attachments

dsage_doctest_threading.patch Download (3.3 KB) - added by yi 2 years ago.

Change History

Changed 2 years ago by yi

Changed 2 years ago by was

  • summary changed from [with patch, needs review] fix for dsage doctest failures in sage-2.11.rc0 to [with patch, positive review] fix for dsage doctest failures in sage-2.11.rc0

Tested on OS X.

Changed 2 years ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in Sage 2.11.final

Note: See TracTickets for help on using tickets.