Ticket #2725 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] MPolynomial_polydict doc-tests and some refactoring

Reported by: jbmohler Owned by: malb
Priority: major Milestone: sage-2.11
Component: commutative algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

The attached patch adds a number of features and refactorings:

  1. A new degrees method which returns the degrees of all the variables in one swoop (and has other useful purposes)
  1. More doc-tests
  1. ETuple helper function to eliminate fragile duplicate code
  1. Fix some latex/repr bugs with -1 (continuation of #291)

Attachments

etuple2.patch Download (28.8 KB) - added by jbmohler 5 years ago.
2725.patch Download (28.4 KB) - added by mhansen 5 years ago.

Change History

Changed 5 years ago by jbmohler

Changed 5 years ago by mhansen

comment:1 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs review] MPolynomial_polydict doc-tests and some refactoring to [with patch, positive review] MPolynomial_polydict doc-tests and some refactoring

Looks good to me. I attached a new version of the patch which plays well with the changes in #2702. Apply that first, and then apply 2725.patch.

comment:2 Changed 5 years ago by mabshoff

Doctests pass with my current 2.11.rc0 merged tree, so I will merge this.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 2.11.rc0

Note: See TracTickets for help on using tickets.