Ticket #2709 (closed enhancement: fixed)
[with patch, positive review] add a prime_above() function to NumberField_generic for finding prime ideals above other ideals
| Reported by: | ncalexan | Owned by: | was |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-2.11 |
| Component: | number theory | Keywords: | number field prime above |
| Cc: | ncalexan, craigcitro | Work issues: | |
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
My research requires reducing curves over number fields modulo prime ideals, so I need to find suitable prime ideals all the time. The attached function does exactly that, albeit naively. I imagine this is useful to more people than me.
Attachments
-
2709-ncalexan-nf-prime-above-1.patch
(3.7 KB) -
added by ncalexan 5 years ago.
-
2709-ncalexan-nf-prime-above-2.patch
(6.3 KB) -
added by ncalexan 5 years ago.
Change History
comment:1 Changed 5 years ago by ncalexan
- Summary changed from add a prime_above() function to NumberField_generic for finding prime ideals above other ideals to [with patch, needs review] add a prime_above() function to NumberField_generic for finding prime ideals above other ideals
comment:5 Changed 5 years ago by ncalexan
After discussion on IRC, generalized to lists and made to raise an error on individual failure. Apply both patches -- sorry for the inconvenience, I couldn't figure out how to cut one patch encompassing both changesets.
comment:6 Changed 5 years ago by AlexGhitza
- Type changed from defect to enhancement
- Summary changed from [with patch, needs review] add a prime_above() function to NumberField_generic for finding prime ideals above other ideals to [with patch, positive review] add a prime_above() function to NumberField_generic for finding prime ideals above other ideals
I like it *a lot*. One small typo: in the docstring for prime_above(), section INPUT, description of the degree, have: "If one, find a prime...". It should be "If None, find a prime..." Of course, one would have to be fairly out of it to be confused by this for too long.
Did I mention that I like it *a lot*?
