Ticket #2684 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] vertices should not default to red

Reported by: jason Owned by: rlm
Priority: minor Milestone: sage-3.0.2
Component: graph theory Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

A student has brought up that having vertices default to red makes the number labels very difficult to read, especially for visually-impaired people.

Attachments

trac-2684-vertex-colors.patch Download (978 bytes) - added by jason 5 years ago.

Change History

comment:1 Changed 5 years ago by jason

The student said that yellow or even pale pink would work much better.

Changed 5 years ago by jason

comment:3 Changed 5 years ago by jason

  • Summary changed from vertices should not default to red to [with patch, needs review] vertices should not default to red

Based on the mailing list conversation, of the two visually-impaired people that looked at the colors, there was:

  • Pink: 1 positive and 1 neutral vote
  • Blue: 1 positive and 1 neutral vote
  • Yellow: 1 positive and 1 negative

I made the default pink and the boundary vertices default to blue.

comment:4 Changed 5 years ago by rlm

  • Summary changed from [with patch, needs review] vertices should not default to red to [with patch, positive review] vertices should not default to red

No new doctests, but I don't see how to do that for this patch anyway. Apply.

comment:5 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.0.2.alpha0

Note: See TracTickets for help on using tickets.