Ticket #2655 (closed enhancement: fixed)

Opened 8 months ago

Last modified 8 months ago

[with patch, merged upstream] Cython circular cdef imports

Reported by: gfurnish Assigned to: gfurnish
Priority: major Milestone: sage-3.0
Component: packages Keywords:
Cc: robertwb

Description

This patch allows circular cdef imports in Cython. It also modifies cython exceptions to also print the line number in the C code. Furthermore the patch begins modifications to seperate module creation from module global execution, which will potentially be useful as Cython starts to employ more optimizations. This patch is required for the symbolics overhaul.

Attachments

trac_2655_cython_9612.patch (20.9 kB) - added by gfurnish on 03/23/2008 09:10:24 AM.
trac_2655_cython_9612.2.patch (22.5 kB) - added by gfurnish on 03/23/2008 09:13:39 AM.
trac_2655_cython_9612.3.patch (25.3 kB) - added by gfurnish on 03/23/2008 09:19:13 AM.
New patch, apply this one *only*. Removes more commented code.
trac_2655_cython_9612_4.patch (0.8 kB) - added by gfurnish on 04/03/2008 06:22:33 PM.
Fix for clear.pyx issue
trac_2655_devel_1.patch (1.3 kB) - added by gfurnish on 04/04/2008 12:33:59 PM.
Fixes doctests for cython 0.9.6.13

Change History

03/23/2008 09:10:24 AM changed by gfurnish

  • attachment trac_2655_cython_9612.patch added.

03/23/2008 09:10:46 AM changed by gfurnish

  • status changed from new to assigned.

03/23/2008 09:13:39 AM changed by gfurnish

  • attachment trac_2655_cython_9612.2.patch added.

03/23/2008 09:15:20 AM changed by gfurnish

Do not apply 9612.patch, apply 9612.2 patch instead. It removed several debug printf statements.

03/23/2008 09:15:36 AM changed by gfurnish

  • cc set to robertwb.

03/23/2008 09:19:13 AM changed by gfurnish

  • attachment trac_2655_cython_9612.3.patch added.

New patch, apply this one *only*. Removes more commented code.

03/23/2008 11:38:43 AM changed by gfurnish

  • type changed from defect to enhancement.

03/23/2008 12:13:05 PM changed by mabshoff

Mhh, shouldn't this go to the Cython mailing list?

Cheers,

Michael

03/26/2008 04:19:18 AM changed by robertwb

I am looking into this, but so far it looks good.

03/27/2008 11:58:26 PM changed by was

Could you post some samples here that don't work with Cython now, but do with your patch applied?

03/30/2008 04:11:08 AM changed by robertwb

This wasn't near as scary of a patch as I had first supposed, good work. I merged it into Cython.

03/30/2008 04:43:04 AM changed by mabshoff

  • summary changed from [with patch, needs review] Cython circular cdef imports to [with patch, merged upstream] Cython circular cdef imports.

04/03/2008 06:22:33 PM changed by gfurnish

  • attachment trac_2655_cython_9612_4.patch added.

Fix for clear.pyx issue

04/03/2008 10:00:09 PM changed by robertwb

Merged upstream.

04/04/2008 12:33:59 PM changed by gfurnish

  • attachment trac_2655_devel_1.patch added.

Fixes doctests for cython 0.9.6.13

04/04/2008 12:35:09 PM changed by gfurnish 

This has the new repository hierarchy, so you won't be able to pull
from the online -devel ones. If no one reports any bugs in then I
will release tomorrow.

http://sage.math.washington.edu/home/robertwb/cython/

- Robert

04/04/2008 01:28:07 PM changed by mabshoff

The spkg at

http://sage.math.washington.edu/home/robertwb/cython/cython-0.9.6.13.spkg

contains a BUILD directory. I removed it and got the size down to about 100kb over 0.9.6.12.

Cheers,

Michael

04/04/2008 01:32:15 PM changed by robertwb

Thanks. This will be removed before the final release.

04/04/2008 02:24:00 PM changed by mabshoff

  • status changed from assigned to closed.
  • resolution set to fixed.

Merged in Sage 3.0.alpha1

(follow-up: ↓ 16 ) 04/04/2008 03:43:54 PM changed by robertwb

Just to confirm, does this mean in the cython-0.9.6.13.spkg from above (minus the build directory) so I needn't make a separate ticket for the new Cython?

(in reply to: ↑ 15 ) 04/04/2008 03:49:06 PM changed by mabshoff

Replying to robertwb:

Just to confirm, does this mean in the cython-0.9.6.13.spkg from above (minus the build directory) so I needn't make a separate ticket for the new Cython?

Correct. The ticket's credit and description reflects this.

Cheers,

Michael

04/08/2008 01:48:08 AM changed by robertwb

The spkg up at

http://sage.math.washington.edu/home/robertwb/cython/

turns c line numbers back on, and has a minor fix for external class declarations (which didn't show up in the Sage codebase, but did for other poeple).

04/08/2008 02:22:59 AM changed by mabshoff

Hi Robert,

I have merged the latest (April 8th) cython.spkg. I saw the message on the Cython mailing list, so I am not surprised that it did come. But I would recommend opening [or reopening] a ticket and also bumping the version number to p0 to reflect this change.

Cheers,

Michael