Ticket #2655 (closed enhancement: fixed)

Opened 16 months ago

Last modified 15 months ago

[with patch, merged upstream] Cython circular cdef imports

Reported by: gfurnish Owned by: gfurnish
Priority: major Milestone: sage-3.0
Component: packages Keywords:
Cc: robertwb Reviewer(s):
Author(s): Merged in:

Description

This patch allows circular cdef imports in Cython. It also modifies cython exceptions to also print the line number in the C code. Furthermore the patch begins modifications to seperate module creation from module global execution, which will potentially be useful as Cython starts to employ more optimizations. This patch is required for the symbolics overhaul.

Attachments

trac_2655_cython_9612.patch (20.9 KB) - added by gfurnish 16 months ago.
trac_2655_cython_9612.2.patch (22.5 KB) - added by gfurnish 16 months ago.
trac_2655_cython_9612.3.patch (25.3 KB) - added by gfurnish 16 months ago.
New patch, apply this one *only*. Removes more commented code.
trac_2655_cython_9612_4.patch (0.8 KB) - added by gfurnish 15 months ago.
Fix for clear.pyx issue
trac_2655_devel_1.patch (1.3 KB) - added by gfurnish 15 months ago.
Fixes doctests for cython 0.9.6.13

Change History

Changed 16 months ago by gfurnish

  Changed 16 months ago by gfurnish

  • status changed from new to assigned

Changed 16 months ago by gfurnish

  Changed 16 months ago by gfurnish

Do not apply 9612.patch, apply 9612.2 patch instead. It removed several debug printf statements.

  Changed 16 months ago by gfurnish

  • cc robertwb added

Changed 16 months ago by gfurnish

New patch, apply this one *only*. Removes more commented code.

  Changed 16 months ago by gfurnish

  • type changed from defect to enhancement

  Changed 16 months ago by mabshoff

Mhh, shouldn't this go to the Cython mailing list?

Cheers,

Michael

  Changed 15 months ago by robertwb

I am looking into this, but so far it looks good.

  Changed 15 months ago by was

Could you post some samples here that don't work with Cython now, but do with your patch applied?

  Changed 15 months ago by robertwb

This wasn't near as scary of a patch as I had first supposed, good work. I merged it into Cython.

  Changed 15 months ago by mabshoff

  • summary changed from [with patch, needs review] Cython circular cdef imports to [with patch, merged upstream] Cython circular cdef imports

Changed 15 months ago by gfurnish

Fix for clear.pyx issue

  Changed 15 months ago by robertwb

Merged upstream.

Changed 15 months ago by gfurnish

Fixes doctests for cython 0.9.6.13

  Changed 15 months ago by gfurnish 

This has the new repository hierarchy, so you won't be able to pull
from the online -devel ones. If no one reports any bugs in then I
will release tomorrow.

http://sage.math.washington.edu/home/robertwb/cython/

- Robert

  Changed 15 months ago by mabshoff

The spkg at

http://sage.math.washington.edu/home/robertwb/cython/cython-0.9.6.13.spkg

contains a BUILD directory. I removed it and got the size down to about 100kb over 0.9.6.12.

Cheers,

Michael

  Changed 15 months ago by robertwb

Thanks. This will be removed before the final release.

  Changed 15 months ago by mabshoff

  • status changed from assigned to closed
  • resolution set to fixed

Merged in Sage 3.0.alpha1

follow-up: ↓ 16   Changed 15 months ago by robertwb

Just to confirm, does this mean in the cython-0.9.6.13.spkg from above (minus the build directory) so I needn't make a separate ticket for the new Cython?

in reply to: ↑ 15   Changed 15 months ago by mabshoff

Replying to robertwb:

Just to confirm, does this mean in the cython-0.9.6.13.spkg from above (minus the build directory) so I needn't make a separate ticket for the new Cython?

Correct. The ticket's credit and description reflects this.

Cheers,

Michael

  Changed 15 months ago by robertwb

The spkg up at

http://sage.math.washington.edu/home/robertwb/cython/

turns c line numbers back on, and has a minor fix for external class declarations (which didn't show up in the Sage codebase, but did for other poeple).

  Changed 15 months ago by mabshoff

Hi Robert,

I have merged the latest (April 8th) cython.spkg. I saw the message on the Cython mailing list, so I am not surprised that it did come. But I would recommend opening [or reopening] a ticket and also bumping the version number to p0 to reflect this change.

Cheers,

Michael

Note: See TracTickets for help on using tickets.