Ticket #2644 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] doctest failures in matrix_real_double_dense

Reported by: dfdeshom Owned by: dfdeshom
Priority: blocker Milestone: sage-2.11
Component: linear algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

On 2.11alpha0, the doctest for __invert__ randomly fails

Attachments

2644.patch Download (1.5 KB) - added by dfdeshom 5 years ago.
patch against 2.11alpha

Change History

Changed 5 years ago by dfdeshom

patch against 2.11alpha

comment:1 Changed 5 years ago by dfdeshom

Here is a patch against 2.11alpha0

comment:2 Changed 5 years ago by dfdeshom

  • Owner changed from was to dfdeshom
  • Summary changed from doctest failures in matrix_real_double_dense to [with patch, needs review] doctest failures in matrix_real_double_dense

comment:3 Changed 5 years ago by AlexGhitza

  • Summary changed from [with patch, needs review] doctest failures in matrix_real_double_dense to [with patch, positive review] doctest failures in matrix_real_double_dense

Looks good and tests fine.

comment:4 Changed 5 years ago by mabshoff

Yep, I think this is the right way to fix this. It is clear from the context that the inversion of the matrix should fail and am somewhat surprised that the numerical noise is large enough that the determinant of a rank deficient matrix like A in this example is not even close to zero.

Cheers,

Michael

comment:5 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 2.11.alpha1

Note: See TracTickets for help on using tickets.