Ticket #2621 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] parallel doctest: concurrency problem when creating .doctest directories

Reported by: mabshoff Owned by: gfurnish
Priority: major Milestone: sage-2.11
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

When parallel doctesting a clean, i.e. never before doctested, tree there are concurrency issues when creating the .doctest directory: 

Traceback (most recent call last):
  File "/scratch/mabshoff/release-cycle/sage-2.11.alpha1/local/bin/sage-doctest", line 427, in <module>
    test_file(argv[1])
  File "/scratch/mabshoff/release-cycle/sage-2.11.alpha1/local/bin/sage-doctest", line 321, in test_file
    os.makedirs(".doctest")
  File "/scratch/mabshoff/release-cycle/sage-2.11.alpha1/local/lib/python2.5/os.py", line 172, in makedirs
    mkdir(name, mode)
OSError: [Errno 17] File exists: '.doctest'

The above is just a scary message and doesn't affect the operation of the doctests. Creating all the .doctest directories before starting to run the doctests would fix the problem.

Cheers,

Michael

Attachments

trac_2621.patch Download (666 bytes) - added by gfurnish 5 years ago.

Change History

Changed 5 years ago by gfurnish

comment:1 Changed 5 years ago by gfurnish

  • Status changed from new to assigned
  • Summary changed from parallell doctest: concurrency problem when creating .doctest directories to [with patch, needs review] parallel doctest: concurrency problem when creating .doctest directories

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, needs review] parallel doctest: concurrency problem when creating .doctest directories to [with patch, positive review] parallel doctest: concurrency problem when creating .doctest directories

Patch looks good to me. Positive review ;)

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 2.11.alpha1

Note: See TracTickets for help on using tickets.