Ticket #2596 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch; positive review] Sage 2.11.alpha0: sage/plot/plot.py doctest failure

Reported by: mabshoff Owned by: failure
Priority: blocker Milestone: sage-2.11
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by mabshoff) (diff) 

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-2.11.alpha0$ ./sage -t -long devel/sage/sage/plot/plot.py
sage -t -long devel/sage-main/sage/plot/plot.py             File "plot.py", line 3513:
    sage: plot(x^(1/3), (x,-1,1))
Expected nothing
Got:
    WARNING: When plotting, failed to evaluate function at 99 points.
    Last error message: 'negative number cannot be raised to a fractional power'
    <BLANKLINE>
**********************************************************************
1 items had failures:
   2 of  28 in __main__.example_111
***Test Failed*** 2 failures.
For whitespace errors, see the file .doctest_plot.py
         [70.3 s]
exit code: 256

Attachments

sage-2596.patch Download (3.9 KB) - added by was 5 years ago.

Change History

comment:1 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to duplicate
  • Milestone changed from sage-2.11 to sage-duplicate/invalid

Mmh, somehow I opened the same ticket twice. This is a dupe of #2583.

Cheers,

Michael

comment:2 Changed 5 years ago by mabshoff

  • Status changed from closed to reopened
  • Resolution duplicate deleted
  • Description modified (diff)
  • Milestone changed from sage-duplicate/invalid to sage-2.11

Ooops, I ended up pasting the wrong doctest failure into the description. Since it now has the corrected version I am reopening this.

Cheers,

Michael

comment:3 Changed 5 years ago by jason

The returned output is correct, so it should be included in the doctest.

"99 points" should be replaced with "...", I think, since sometimes it will be "100 points" (due to random shifts in the points). We could just set randomize=False, but that would make for a more confusing example, I think.

Changed 5 years ago by was

comment:4 Changed 5 years ago by was

  • Summary changed from Sage 2.11.alpha0: sage/plot/plot.py doctest failure to [with patch; needs review] Sage 2.11.alpha0: sage/plot/plot.py doctest failure

comment:5 Changed 5 years ago by mabshoff

  • Summary changed from [with patch; needs review] Sage 2.11.alpha0: sage/plot/plot.py doctest failure to [with patch; positive review] Sage 2.11.alpha0: sage/plot/plot.py doctest failure

Patch looks good to me. Positive review.

comment:6 Changed 5 years ago by mabshoff

  • Status changed from reopened to closed
  • Resolution set to fixed

Merged in Sage 2.11.alpha2

Note: See TracTickets for help on using tickets.