Ticket #2595 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, with positive review] rubiks and polymake both have a cube binary

Reported by: mabshoff Owned by: mabshoff
Priority: blocker Milestone: sage-2.11
Component: packages: standard Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

When one installs the optional polymake.spkg the cube doctest fails since somehow polymake's cube is in $PATH before rubik's cube: 

./local/bin/cube
./local/polymake/bin/cube

I would suggest changing the name of the binary from rubiks.spkg.

Cheers,

Michael

Attachments

trac_2595.patch Download (645 bytes) - added by mabshoff 5 years ago.
trivial patch to rename the binary in DikSolver?

Change History

comment:1 Changed 5 years ago by mabshoff

  • Status changed from new to assigned

Changed 5 years ago by mabshoff

trivial patch to rename the binary in DikSolver?

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from rubiks and polymake both have a cube binary to [with patch, needs trivial review] rubiks and polymake both have a cube binary

comment:3 Changed 5 years ago by gfurnish

  • Summary changed from [with patch, needs trivial review] rubiks and polymake both have a cube binary to [with patch, with positive review] rubiks and polymake both have a cube binary

Looks good

comment:4 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 2.11.alpha1. The corresponding fix to the makefile of rubiks.spkg will be in #2287.

Note: See TracTickets for help on using tickets.