Ticket #2541 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] Fixes bugs in binary_code.pyx

Reported by: rlm Owned by: rlm
Priority: major Milestone: sage-2.10.4
Component: coding theory Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

This also makes the automorphism group calculator return the size of the group.

Attachments

2541-binary_code.patch Download (22.4 KB) - added by rlm 5 years ago.

Change History

Changed 5 years ago by rlm

comment:1 Changed 5 years ago by rlm

  • Summary changed from [with patch, needs review] Fixes bugs in binary_codes.pyx to [with patch, needs review] Fixes bugs in binary_code.pyx

This may fix one of the issues mentioned in #2514. At the very least it adds doctests that show that if there still is a problem, it isn't in binary_code.pyx.

comment:2 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs review] Fixes bugs in binary_code.pyx to [with patch, positive review] Fixes bugs in binary_code.pyx

Applies and passes tests for me.

comment:3 Changed 5 years ago by mabshoff

I will remove the colorful language once I merge this patch :)

Cheers,

Michael

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 2.10.4.rc0 (minus one line ;)

Note: See TracTickets for help on using tickets.