Ticket #2479 (closed defect: fixed)
[with patch; with positive review] RDF polynomial factoring bug
| Reported by: | was | Owned by: | somebody |
|---|---|---|---|
| Priority: | major | Milestone: | sage-2.10.4 |
| Component: | basic arithmetic | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
sage: x = polygen(RDF,'x') sage: (-2*x^2 - 1).factor() []
degree 4?
Attachments
-
sage-2479.patch
(3.2 KB) -
added by was 5 years ago.
-
trac-2479-v2.patch
(3.9 KB) -
added by craigcitro 5 years ago.
- same patch as above, but applies clean against 2.10.3
Change History
comment:1 Changed 5 years ago by was
- Summary changed from RDF polynomial factoring bug to [with patch; needs review] RDF polynomial factoring bug
Attached patch fixes this problem.
comment:2 Changed 5 years ago by craigcitro
- Summary changed from [with patch; needs review] RDF polynomial factoring bug to [with patch; with positive review] RDF polynomial factoring bug
Yep, looks good.
I'm giving this a positive review, even though I had trouble applying this patch on my home machine. I think something got screwed up with my home machine's install, because it was an upgrade from 2.10.1 to 2.10.2 to 2.10.3. I tested, and the patch applies just fine against the copy of 2.10.3.rc1 I have on sage.math, so I'm pretty sure this is a local problem with my setup. Maybe it's an issue with upgrades from 2.10.2 to 2.10.3? In any event, it shouldn't be a problem for whoever is rolling 2.10.3.1 or whatnot.
comment:3 Changed 5 years ago by craigcitro
- Summary changed from [with patch; with positive review] RDF polynomial factoring bug to [with patch; with semi-positive review] RDF polynomial factoring bug
Actually, I take it back. I think that the version that William made this patch against isn't 2.10.3, because the same hunk that failed for me will fail on sage.math and another upgrade that just finished for me. I'm going to submit a second patch in about 30 seconds; one of the two should work.
comment:4 Changed 5 years ago by craigcitro
Ok, re-based the patch. The name on the commit should get changed to William, since it's really his patch.
comment:5 Changed 5 years ago by craigcitro
- Summary changed from [with patch; with semi-positive review] RDF polynomial factoring bug to [with patch; with positive review] RDF polynomial factoring bug
Changed 5 years ago by craigcitro
-
attachment
trac-2479-v2.patch
added
same patch as above, but applies clean against 2.10.3
