Ticket #2456 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] matrix_symbolic_dense doctest failures

Reported by: gfurnish Owned by: gfurnish
Priority: critical Milestone: sage-2.10.3
Component: linear algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

File "matrix_symbolic_dense.pyx", line 873:
    sage: list(a.fcp())
Expected:
    [(x^2 - 65*x - 250, 1), (x, 3)]
Got:
    [(x, 3), (x^2 - 65*x - 250, 1)]

But inside sage: 

sage: a = matrix(SR, 5, [1..5^2]) 
sage: a.fcp()
(x^2 - 65*x - 250) * x^3
sage: list(a.fcp())
[(x^2 - 65*x - 250, 1), (x, 3)]

Attachments

trac_2456.patch Download (1.6 KB) - added by gfurnish 5 years ago.

Change History

comment:1 Changed 5 years ago by gfurnish

  • Summary changed from matrix_symbolic_dense doctest failures to [with patch, needs review] matrix_symbolic_dense doctest failures

This patch is correct because of changes in #2206

comment:2 Changed 5 years ago by gfurnish

  • Owner changed from was to gfurnish
  • Status changed from new to assigned

comment:3 Changed 5 years ago by gfurnish

This patch fixes problems in factorization that cause problems here.

comment:4 Changed 5 years ago by was

  • Summary changed from [with patch, needs review] matrix_symbolic_dense doctest failures to [with patch, accepted pending revision] matrix_symbolic_dense doctest failures

REFEREE REPORT:

  • The second chunk in trac_2456.patch, which swaps the order of sort and simplify, breaks things. This is because simplify assumes its input is sorted, as it combines adjacent pairs.
  • The rest of the patch looks fine.

Changed 5 years ago by gfurnish

comment:5 Changed 5 years ago by was

  • Summary changed from [with patch, accepted pending revision] matrix_symbolic_dense doctest failures to [with patch, positive review] matrix_symbolic_dense doctest failures

replaced patch addresses my concern.

comment:6 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 2.10.3.rc4

Note: See TracTickets for help on using tickets.