Ticket #2448 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] add docstrings, clean code in quadratic_forms

Reported by: ncalexan Owned by: was
Priority: minor Milestone: sage-2.10.4
Component: number theory Keywords: quadratic forms doc days docstring doctest
Cc: ncalexan Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

I can't improve anything with the 2-adic genera stuff, unfo.

Attachments

2448-ncalexan-doc-quadratic_forms-1.patch Download (12.8 KB) - added by ncalexan 5 years ago.

Change History

Changed 5 years ago by ncalexan

comment:1 Changed 5 years ago by rlm

  • Milestone changed from sage-2.11 to sage-2.10.4

comment:2 Changed 5 years ago by AlexGhitza

  • Summary changed from [with patch, needs review] add docstrings, clean code in quadratic_forms to [with patch, positive review] add docstrings, clean code in quadratic_forms

Excellent job cleaning things up and improving the documentation!

comment:3 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 2.10.4.rc0

Note: See TracTickets for help on using tickets.