Ticket #2227 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] sage-2.10.2.alpha1 -- doctest broken in sageinspect.py because I added a new option

Reported by: was Owned by: mabshoff
Priority: blocker Milestone: sage-2.10.2
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

	 [8.8 s]
sage -t  devel/sage-main/sage/misc/sageinspect.py           **********************************************************************
File "sageinspect.py", line 412:
    sage: sage_getdef(sage.rings.integer.Integer.factor, obj_name='factor')
Expected:
    "factor(algorithm='pari', proof='True')"
Got:
    "factor(algorithm='pari', proof='True', limit='None')"
**********************************************************************
1 items had failures:
   1 of  24 in __main__.example_10
***Test Failed*** 1 failures.

FIX -- just change the doctest -- this makes perfect sense. (I added a new limit option to factor).

Attachments

trac_2227_sageinspect_doctest_fix.patch Download (881 bytes) - added by mabshoff 5 years ago.
Fix doctest as indicated by William

Change History

comment:1 Changed 5 years ago by mabshoff

  • Owner changed from failure to mabshoff
  • Status changed from new to assigned

Changed 5 years ago by mabshoff

Fix doctest as indicated by William

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from sage-2.10.2.alpha1 -- doctest broken in sageinspect.py because I added a new option to [with patch, needs review] sage-2.10.2.alpha1 -- doctest broken in sageinspect.py because I added a new option

comment:3 Changed 5 years ago by jason

  • Summary changed from [with patch, needs review] sage-2.10.2.alpha1 -- doctest broken in sageinspect.py because I added a new option to [with patch, positive review] sage-2.10.2.alpha1 -- doctest broken in sageinspect.py because I added a new option

looks good.

comment:4 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 2.10.2.alpha2

Note: See TracTickets for help on using tickets.