Ticket #2002 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, with positive review] creating a fresh new notebook in sage-2.10.1.rc3 is broken

Reported by: was Owned by: boothby
Priority: blocker Milestone: sage-2.10.1
Component: notebook Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

[02:20am] william_stein: the notebook doesn't even work in rc3!!
[02:21am] william_stein: sage: notebook(address="sage.math.washington.edu", port=8389, directory="notebook")
[02:21am] william_stein: ...
[02:21am] william_stein: <type 'exceptions.AttributeError'>: 'Notebook' object has no attribute 'set_prettyprint'
[02:21am] william_stein: This is what happens when making a NEW NOTEBOOK not loading an existing one.
[02:21am] william_stein: I'm glad I caught this!!
[02:21am] william_stein: trac ticket coming up

Attachments

pretty-print-notebook.patch Download (7.5 KB) - added by jason 5 years ago.

Change History

comment:1 Changed 5 years ago by jason

  • Summary changed from creating a fresh new notebook in sage-2.10.1.rc3 is broken to [with patch, needs review] creating a fresh new notebook in sage-2.10.1.rc3 is broken

I think the attached fixes the issue, but I'm not sure how to create a new notebook, so I'm not sure how to test it.

comment:2 Changed 5 years ago by jason

(which probably explains why this was never tested when submitting the original patch. sorry!)

Changed 5 years ago by jason

comment:3 Changed 5 years ago by jason

The attached patch also standardizes on "pretty_print" instead of "prettyprint". The previous code had a mixture of the two spellings.

comment:4 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, needs review] creating a fresh new notebook in sage-2.10.1.rc3 is broken to [with patch, with cautious positive review] creating a fresh new notebook in sage-2.10.1.rc3 is broken

The issue has been solved, but I do believe that somebody else ought to double check this.

Cheers,

Michael

comment:5 Changed 5 years ago by jkantor

  • Summary changed from [with patch, with cautious positive review] creating a fresh new notebook in sage-2.10.1.rc3 is broken to [with patch, with positive review] creating a fresh new notebook in sage-2.10.1.rc3 is broken

The issue appears to have been solved to me as well.

comment:6 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 2.10.1.rc4

Note: See TracTickets for help on using tickets.