Ticket #1785 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, with positive review] bug in creating points on elliptic curves over extension fields

Reported by: was Owned by: was
Priority: major Milestone: sage-3.1.2
Component: algebraic geometry Keywords:
Cc: AlexGhitza Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description


On Jan 15, 2008 10:25 AM, John Cremona <john.cremona@gmail.com> wrote:
> 
> I like Robert's suggestion.  If the user wants n independent generic
> points, construct a large enough field (transcendence degree n) to
> contain them.
> 
> A useful change Magma made relatively recently (a couple of years or
> so ago) was to aloow points on an elliptic curve to have coordinates
> in an extension of the base field of the curve -- as one would when
> working mathematically.  e.g. given a curve defined over QQ you can
> define points on E(K) for e.g. K=a number field, or K=a function field
> (such as the function field of E, to get a generic point).  Of course,
> these points "know" what their curve is so you can do point arithmetic
> on them and so on.
> 
> I don't see why this should be workable in Sage too (maybe it is
> already?  if so I will retire shame-faced from the discussion...)

It's sort of half-way there.  You can do:

sage: K.<a> = NumberField(x^2 + x - (3^3-3))
sage: E = EllipticCurve('37a')
sage: X = E(K)

but stupidly X is wrong:

sage: X
Abelian group of points on Elliptic Curve defined by y^2 + y = x^3 - x over Rational Field

though:

sage: X.domain()
Spectrum of Number Field in a with defining polynomial x^2 + x - 24

However, 

sage: P = X([3,a]);
boom with a TypeError

So this obviously needs work.  In fact, this counts as a bug.

Attachments

1785-ell_point_ext.patch Download (1.4 KB) - added by AlexGhitza 5 years ago.

Change History

comment:1 Changed 5 years ago by AlexGhitza

  • Cc AlexGhitza added

Changed 5 years ago by AlexGhitza

comment:2 Changed 5 years ago by AlexGhitza

  • Summary changed from bug in creating points on elliptic curves over extension fields to [with patch, needs review] bug in creating points on elliptic curves over extension fields

See the patch (made against 3.1.2.rc0).

comment:3 Changed 5 years ago by cremona

  • Summary changed from [with patch, needs review] bug in creating points on elliptic curves over extension fields to [with patch, with positive review] bug in creating points on elliptic curves over extension fields

Review: Amazing 2-line fix! Patch applies fine and all doctests in sage.schemes.elliptic_curves pass. This will be very useful.

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.1.2.rc1

Note: See TracTickets for help on using tickets.