Ticket #1733 (closed defect: fixed)
[with patch; positive review] notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should*
| Reported by: | was | Owned by: | boothby |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.0.2 |
| Component: | notebook | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
This is probably easy to fix in server/notebook/worksheet.py
Attachments
Change History
comment:1 Changed 5 years ago by was
- Summary changed from notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should* to [with patch; needs review] notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should*
The attached patch:
- Fixed the problem where %foobar with no input in the cell didn't give an error -- now it does, about
foobar not being defined.
- While I was at it I improved how %foo modes in the notebook work, so that they can have everything on one line, e.g.,
%magma Factorization(9038049823)
on a single line works in the notebook.
- NOTE that the actual patch replaces a bunch of crappy hard to understand code with like 3 simple
lines that fix all of the above.
comment:2 Changed 5 years ago by boothby
- Summary changed from [with patch; needs review] notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should* to [with patch; positive review] notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should*
Great stuff! Works well, and makes the code cleaner!
Note: See
TracTickets for help on using
tickets.

