Ticket #1614 (closed defect: fixed)

Opened 3 years ago

Last modified 22 months ago

cleanup setup.py in sage.spkg

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-3.2
Component: distribution Keywords:
Cc: craigcitro Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

We have a lot of extensions directly listed in the ext_modules section. Move those out and also sort the ext_modules list

Change History

Changed 3 years ago by robertwb

Is there any reason to not list extensions directly in the ext_modules list? This seems far simpler and less error prone. If anything needs to change, I'd move all of them there.

Changed 3 years ago by mabshoff

  • milestone changed from sage-2.9.2 to sage-2.10

Well, as it it just seems very inconsistent. We can move it either way, it should just be consistent. I have a Cygwin build patch for setup.py that should be applied before anybody else touches setup.py with some major reorg patch. The is needed because the order of libraries matters on Cygwin. That patch is one of the first patches that I plan to merge for 2.10 as I am reluctant to merge it now for 2.9.2.

Cheers,

Michael

Changed 22 months ago by mabshoff

  • cc craigcitro added
  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from sage-3.2.1 to sage-3.2

This issue has been fixed via #4480 by Craig Citro.

Cheers,

Michael

Note: See TracTickets for help on using tickets.